Merge pull request #28 from twbs/tooltip-display-none-error

throw error when trying to show tooltip on :hidden element

js/tests/unit/popover.js

@@ -166,7 +166,8 @@ $(function () {
 
   QUnit.test('should destroy popover', function (assert) {
     assert.expect(7)
-    var $popover = $('<div/>')
+    var $popover = $('<div>Popover trigger</div>')
+      .appendTo('#qunit-fixture')
       .bootstrapPopover({
         trigger: 'hover'
       })
@@ -240,6 +241,17 @@ $(function () {
       .bootstrapPopover('show')
   })
 
+  QUnit.test('should throw an error when trying to show a popover on a hidden element', function (assert) {
+    assert.expect(1)
+    var $target = $('<a href="#" title="Another popover" data-content="Body" style="display: none;">I am hidden</a>').appendTo('#qunit-fixture')
+
+    assert.throws(function () {
+      $target.bootstrapPopover('show')
+    }, new Error('Can\'t show a tooltip/popover on a hidden element'))
+
+    $target.remove()
+  })
+
   QUnit.test('should throw an error when initializing popover on the document object without specifying a delegation selector', function (assert) {
     assert.expect(1)
     assert.throws(function () {

js/tooltip.js

@@ -293,6 +293,14 @@ Tooltip.prototype['destroy'] = function () {
  * and replace with external lib
  */
 Tooltip.prototype['show'] = function () {
+  // jQuery's :hidden gives false positives for SVG elements
+  // See https://github.com/jquery/jquery/pull/939
+  // Since this hiddenness check is just a nicety anyway, simply assume SVGs are always visible.
+  var isHidden = $(this.element).is(':hidden') && !(window.SVGElement && this.element instanceof window.SVGElement)
+  if (isHidden) {
+    throw new Error('Can\'t show a tooltip/popover on a hidden element')
+  }
+
   var showEvent = $.Event(this.getEventObject().SHOW)
 
   if (this.isWithContent() && this._isEnabled) {