Commit 92245e8b authored by fat's avatar fat

change dropdown strategy to use an overlay - fixes mobile click anywhere +...

change dropdown strategy to use an overlay - fixes mobile click anywhere + allows for firefox middle click
parent bdbd268c
...@@ -2799,6 +2799,15 @@ input[type="button"].btn-block { ...@@ -2799,6 +2799,15 @@ input[type="button"].btn-block {
outline: 0; outline: 0;
} }
.dropdown-backdrop {
position: fixed;
top: 0;
right: 0;
bottom: 0;
left: 0;
z-index: 990;
}
.pull-right > .dropdown-menu { .pull-right > .dropdown-menu {
right: 0; right: 0;
left: auto; left: auto;
......
This diff is collapsed.
This diff is collapsed.
...@@ -18,132 +18,117 @@ ...@@ -18,132 +18,117 @@
* ============================================================ */ * ============================================================ */
!function ($) { !function ($) { "use strict";
"use strict"; // jshint ;_; // COLLAPSE PUBLIC CLASS DEFINITION
// ================================
/* COLLAPSE PUBLIC CLASS DEFINITION
* ================================ */
var Collapse = function (element, options) { var Collapse = function (element, options) {
this.$element = $(element) this.$element = $(element)
this.options = $.extend({}, $.fn.collapse.defaults, options) this.options = $.extend({}, Collapse.DEFAULTS, options)
this.transitioning = null
if (this.options.parent) { if (this.options.parent) this.$parent = $(this.options.parent)
this.$parent = $(this.options.parent) if (this.options.toggle) this.toggle()
} }
this.options.toggle && this.toggle() Collapse.DEFAULTS = {
toggle: true
} }
Collapse.prototype = { Collapse.prototype.dimension = function () {
var hasWidth = this.$element.hasClass('width')
return hasWidth ? 'width' : 'height'
}
constructor: Collapse Collapse.prototype.show = function () {
if (this.transitioning || this.$element.hasClass('in')) return
, dimension: function () { var dimension = this.dimension()
var hasWidth = this.$element.hasClass('width') var scroll = $.camelCase(['scroll', dimension].join('-'))
return hasWidth ? 'width' : 'height' var actives = this.$parent && this.$parent.find('> .accordion-group > .in')
}
, show: function () { if (actives && actives.length) {
var dimension var hasData = actives.data('collapse')
, scroll if (hasData && hasData.transitioning) return
, actives actives.collapse('hide')
, hasData hasData || actives.data('collapse', null)
}
if (this.transitioning || this.$element.hasClass('in')) return
dimension = this.dimension() this.$element[dimension](0)
scroll = $.camelCase(['scroll', dimension].join('-')) this.transition('addClass', $.Event('show'), 'shown')
actives = this.$parent && this.$parent.find('> .accordion-group > .in')
if (actives && actives.length) { if ($.support.transition) this.$element[dimension](this.$element[0][scroll])
hasData = actives.data('collapse') }
if (hasData && hasData.transitioning) return
actives.collapse('hide')
hasData || actives.data('collapse', null)
}
this.$element[dimension](0) Collapse.prototype.hide = function () {
this.transition('addClass', $.Event('show'), 'shown') if (this.transitioning || !this.$element.hasClass('in')) return
$.support.transition && this.$element[dimension](this.$element[0][scroll]) var dimension = this.dimension()
} this.reset(this.$element[dimension]())
this.transition('removeClass', $.Event('hide'), 'hidden')
this.$element[dimension](0)
}
, hide: function () { Collapse.prototype.reset = function (size) {
var dimension var dimension = this.dimension()
if (this.transitioning || !this.$element.hasClass('in')) return
dimension = this.dimension()
this.reset(this.$element[dimension]())
this.transition('removeClass', $.Event('hide'), 'hidden')
this.$element[dimension](0)
}
, reset: function (size) { this.$element
var dimension = this.dimension() .removeClass('collapse')
[dimension](size || 'auto')
[0].offsetWidth
this.$element this.$element[size !== null ? 'addClass' : 'removeClass']('collapse')
.removeClass('collapse')
[dimension](size || 'auto')
[0].offsetWidth
this.$element[size !== null ? 'addClass' : 'removeClass']('collapse') return this
}
return this Collapse.prototype.transition = function (method, startEvent, completeEvent) {
var that = this
var complete = function () {
if (startEvent.type == 'show') that.reset()
that.transitioning = 0
that.$element.trigger(completeEvent)
} }
, transition: function (method, startEvent, completeEvent) { this.$element.trigger(startEvent)
var that = this
, complete = function () {
if (startEvent.type == 'show') that.reset()
that.transitioning = 0
that.$element.trigger(completeEvent)
}
this.$element.trigger(startEvent)
if (startEvent.isDefaultPrevented()) return if (startEvent.isDefaultPrevented()) return
this.transitioning = 1 this.transitioning = 1
this.$element[method]('in') this.$element[method]('in')
$.support.transition && this.$element.hasClass('collapse') ? $.support.transition && this.$element.hasClass('collapse') ?
this.$element.one($.support.transition.end, complete) : this.$element.one($.support.transition.end, complete) :
complete() complete()
} }
, toggle: function () {
this[this.$element.hasClass('in') ? 'hide' : 'show']()
}
Collapse.prototype.toggle = function () {
this[this.$element.hasClass('in') ? 'hide' : 'show']()
} }
/* COLLAPSE PLUGIN DEFINITION // COLLAPSE PLUGIN DEFINITION
* ========================== */ // ==========================
var old = $.fn.collapse var old = $.fn.collapse
$.fn.collapse = function (option) { $.fn.collapse = function (option) {
return this.each(function () { return this.each(function () {
var $this = $(this) var $this = $(this)
, data = $this.data('collapse') var data = $this.data('collapse')
, options = $.extend({}, $.fn.collapse.defaults, $this.data(), typeof option == 'object' && option) var options = $.extend({}, Collapse.DEFAULTS, $this.data(), typeof option == 'object' && option)
if (!data) $this.data('collapse', (data = new Collapse(this, options))) if (!data) $this.data('collapse', (data = new Collapse(this, options)))
if (typeof option == 'string') data[option]() if (typeof option == 'string') data[option]()
}) })
} }
$.fn.collapse.defaults = {
toggle: true
}
$.fn.collapse.Constructor = Collapse $.fn.collapse.Constructor = Collapse
/* COLLAPSE NO CONFLICT // COLLAPSE NO CONFLICT
* ==================== */ // ====================
$.fn.collapse.noConflict = function () { $.fn.collapse.noConflict = function () {
$.fn.collapse = old $.fn.collapse = old
...@@ -151,15 +136,16 @@ ...@@ -151,15 +136,16 @@
} }
/* COLLAPSE DATA-API // COLLAPSE DATA-API
* ================= */ // =================
$(document).on('click.collapse.data-api', '[data-toggle=collapse]', function (e) { $(document).on('click.collapse.data-api', '[data-toggle=collapse]', function (e) {
var $this = $(this), href var $this = $(this), href
, target = $this.attr('data-target') var target = $this.attr('data-target')
|| e.preventDefault() || e.preventDefault()
|| (href = $this.attr('href')) && href.replace(/.*(?=#[^\s]+$)/, '') //strip for ie7 || (href = $this.attr('href')) && href.replace(/.*(?=#[^\s]+$)/, '') //strip for ie7
, option = $(target).data('collapse') ? 'toggle' : $this.data() var option = $(target).data('collapse') ? 'toggle' : $this.data()
$this[$(target).hasClass('in') ? 'addClass' : 'removeClass']('collapsed') $this[$(target).hasClass('in') ? 'addClass' : 'removeClass']('collapsed')
$(target).collapse(option) $(target).collapse(option)
}) })
......
...@@ -18,123 +18,101 @@ ...@@ -18,123 +18,101 @@
* ============================================================ */ * ============================================================ */
!function ($) { !function ($) { "use strict";
"use strict"; // jshint ;_;
// DROPDOWN CLASS DEFINITION
// =========================
/* DROPDOWN CLASS DEFINITION var backdrop = '.dropdown-backdrop'
* ========================= */ var toggle = '[data-toggle=dropdown]'
var Dropdown = function (element) {
var toggle = '[data-toggle=dropdown]' var $el = $(element).on('click.dropdown.data-api', this.toggle)
, Dropdown = function (element) { $('html').on('click.dropdown.data-api', function () {
var $el = $(element).on('click.dropdown.data-api', this.toggle) $el.parent().removeClass('open')
$('html').on('click.dropdown.data-api', function () { })
$el.parent().removeClass('open') }
})
}
Dropdown.prototype = {
constructor: Dropdown
, toggle: function (e) {
var $this = $(this)
, $parent
, isActive
if ($this.is('.disabled, :disabled')) return
$parent = getParent($this)
isActive = $parent.hasClass('open') Dropdown.prototype.toggle = function (e) {
var $this = $(this)
clearMenus() if ($this.is('.disabled, :disabled')) return
if (!isActive) { var $parent = getParent($this)
$parent.toggleClass('open') var isActive = $parent.hasClass('open')
}
$this.focus() clearMenus()
return false if (!isActive) {
$('<div class="dropdown-backdrop"/>').insertBefore($(this)).on('click', clearMenus)
$parent.toggleClass('open')
} }
, keydown: function (e) { $this.focus()
var $this
, $items
, $active
, $parent
, isActive
, index
if (!/(38|40|27)/.test(e.keyCode)) return return false
}
$this = $(this)
e.preventDefault() Dropdown.prototype.keydown = function (e) {
e.stopPropagation() if (!/(38|40|27)/.test(e.keyCode)) return
if ($this.is('.disabled, :disabled')) return var $this = $(this)
$parent = getParent($this) e.preventDefault()
e.stopPropagation()
isActive = $parent.hasClass('open') if ($this.is('.disabled, :disabled')) return
if (!isActive || (isActive && e.keyCode == 27)) { var $parent = getParent($this)
if (e.which == 27) $parent.find(toggle).focus() var isActive = $parent.hasClass('open')
return $this.click()
}
$items = $('[role=menu] li:not(.divider):visible a', $parent) if (!isActive || (isActive && e.keyCode == 27)) {
if (e.which == 27) $parent.find(toggle).focus()
return $this.click()
}
if (!$items.length) return var $items = $('[role=menu] li:not(.divider):visible a', $parent)
index = $items.index($items.filter(':focus')) if (!$items.length) return
if (e.keyCode == 38 && index > 0) index-- // up var index = $items.index($items.filter(':focus'))
if (e.keyCode == 40 && index < $items.length - 1) index++ // down
if (!~index) index = 0
$items if (e.keyCode == 38 && index > 0) index-- // up
.eq(index) if (e.keyCode == 40 && index < $items.length - 1) index++ // down
.focus() if (!~index) index=0
}
$items.eq(index).focus()
} }
function clearMenus() { function clearMenus() {
$(toggle).each(function () { $(backdrop).remove()
getParent($(this)).removeClass('open') $(toggle).each(function () { getParent($(this)).removeClass('open') })
})
} }
function getParent($this) { function getParent($this) {
var selector = $this.attr('data-target') var selector = $this.attr('data-target')
, $parent
if (!selector) { if (!selector) {
selector = $this.attr('href') selector = $this.attr('href')
selector = selector && /#/.test(selector) && selector.replace(/.*(?=#[^\s]*$)/, '') //strip for ie7 selector = selector && /#/.test(selector) && selector.replace(/.*(?=#[^\s]*$)/, '') //strip for ie7
} }
$parent = selector && $(selector) var $parent = selector && $(selector)
if (!$parent || !$parent.length) $parent = $this.parent()
return $parent return $parent && $parent.length ? $parent : $this.parent()
} }
/* DROPDOWN PLUGIN DEFINITION // DROPDOWN PLUGIN DEFINITION
* ========================== */ // ==========================
var old = $.fn.dropdown var old = $.fn.dropdown
$.fn.dropdown = function (option) { $.fn.dropdown = function (option) {
return this.each(function () { return this.each(function () {
var $this = $(this) var $this = $(this)
, data = $this.data('dropdown') var data = $this.data('dropdown')
if (!data) $this.data('dropdown', (data = new Dropdown(this))) if (!data) $this.data('dropdown', (data = new Dropdown(this)))
if (typeof option == 'string') data[option].call($this) if (typeof option == 'string') data[option].call($this)
}) })
...@@ -143,8 +121,8 @@ ...@@ -143,8 +121,8 @@
$.fn.dropdown.Constructor = Dropdown $.fn.dropdown.Constructor = Dropdown
/* DROPDOWN NO CONFLICT // DROPDOWN NO CONFLICT
* ==================== */ // ====================
$.fn.dropdown.noConflict = function () { $.fn.dropdown.noConflict = function () {
$.fn.dropdown = old $.fn.dropdown = old
...@@ -152,13 +130,12 @@ ...@@ -152,13 +130,12 @@
} }
/* APPLY TO STANDARD DROPDOWN ELEMENTS // APPLY TO STANDARD DROPDOWN ELEMENTS
* =================================== */ // ===================================
$(document) $(document)
.on('click.dropdown.data-api', clearMenus)
.on('click.dropdown.data-api', '.dropdown form', function (e) { e.stopPropagation() }) .on('click.dropdown.data-api', '.dropdown form', function (e) { e.stopPropagation() })
.on('click.dropdown-menu', function (e) { e.stopPropagation() })
.on('click.dropdown.data-api' , toggle, Dropdown.prototype.toggle) .on('click.dropdown.data-api' , toggle, Dropdown.prototype.toggle)
.on('keydown.dropdown.data-api', toggle + ', [role=menu]' , Dropdown.prototype.keydown) .on('keydown.dropdown.data-api', toggle + ', [role=menu]' , Dropdown.prototype.keydown)
......
...@@ -346,8 +346,8 @@ $('#myModal').on('hidden', function () { ...@@ -346,8 +346,8 @@ $('#myModal').on('hidden', function () {
<li class="dropdown"> <li class="dropdown">
<a id="drop1" href="#" role="button" class="dropdown-toggle" data-toggle="dropdown">Dropdown <b class="caret"></b></a> <a id="drop1" href="#" role="button" class="dropdown-toggle" data-toggle="dropdown">Dropdown <b class="caret"></b></a>
<ul class="dropdown-menu" role="menu" aria-labelledby="drop1"> <ul class="dropdown-menu" role="menu" aria-labelledby="drop1">
<li role="presentation"><a role="menuitem" tabindex="-1" href="http://google.com">Action</a></li> <li role="presentation"><a role="menuitem" tabindex="-1" href="#">Action</a></li>
<li role="presentation"><a role="menuitem" tabindex="-1" href="#anotherAction">Another action</a></li> <li role="presentation"><a role="menuitem" tabindex="-1" href="#">Another action</a></li>
<li role="presentation"><a role="menuitem" tabindex="-1" href="#">Something else here</a></li> <li role="presentation"><a role="menuitem" tabindex="-1" href="#">Something else here</a></li>
<li role="presentation" class="divider"></li> <li role="presentation" class="divider"></li>
<li role="presentation"><a role="menuitem" tabindex="-1" href="#">Separated link</a></li> <li role="presentation"><a role="menuitem" tabindex="-1" href="#">Separated link</a></li>
...@@ -412,7 +412,7 @@ $('#myModal').on('hidden', function () { ...@@ -412,7 +412,7 @@ $('#myModal').on('hidden', function () {
<li role="presentation"><a role="menuitem" tabindex="-1" href="#">Another action</a></li> <li role="presentation"><a role="menuitem" tabindex="-1" href="#">Another action</a></li>
<li role="presentation"><a role="menuitem" tabindex="-1" href="#">Something else here</a></li> <li role="presentation"><a role="menuitem" tabindex="-1" href="#">Something else here</a></li>
<li role="presentation" class="divider"></li> <li role="presentation" class="divider"></li>
<li role="presentation"><a role="menuitem" tabindex="-1" href="#">Separated link</a></li> <li role="presentation"><a role="menuitem" tabindex="-1" href="http://google.com">Separated link</a></li>
</ul> </ul>
</li> </li>
</ul> <!-- /tabs --> </ul> <!-- /tabs -->
......
...@@ -18,123 +18,101 @@ ...@@ -18,123 +18,101 @@
* ============================================================ */ * ============================================================ */
!function ($) { !function ($) { "use strict";
"use strict"; // jshint ;_;
// DROPDOWN CLASS DEFINITION
// =========================
/* DROPDOWN CLASS DEFINITION var backdrop = '.dropdown-backdrop'
* ========================= */ var toggle = '[data-toggle=dropdown]'
var Dropdown = function (element) {
var toggle = '[data-toggle=dropdown]' var $el = $(element).on('click.dropdown.data-api', this.toggle)
, Dropdown = function (element) { $('html').on('click.dropdown.data-api', function () {
var $el = $(element).on('click.dropdown.data-api', this.toggle) $el.parent().removeClass('open')
$('html').on('click.dropdown.data-api', function () { })
$el.parent().removeClass('open') }
})
}
Dropdown.prototype = {
constructor: Dropdown
, toggle: function (e) {
var $this = $(this)
, $parent
, isActive
if ($this.is('.disabled, :disabled')) return
$parent = getParent($this)
isActive = $parent.hasClass('open') Dropdown.prototype.toggle = function (e) {
var $this = $(this)
clearMenus() if ($this.is('.disabled, :disabled')) return
if (!isActive) { var $parent = getParent($this)
$parent.toggleClass('open') var isActive = $parent.hasClass('open')
}
$this.focus() clearMenus()
return false if (!isActive) {
$('<div class="dropdown-backdrop"/>').insertBefore($(this)).on('click', clearMenus)
$parent.toggleClass('open')
} }
, keydown: function (e) { $this.focus()
var $this
, $items
, $active
, $parent
, isActive
, index
if (!/(38|40|27)/.test(e.keyCode)) return return false
}
$this = $(this)
e.preventDefault() Dropdown.prototype.keydown = function (e) {
e.stopPropagation() if (!/(38|40|27)/.test(e.keyCode)) return
if ($this.is('.disabled, :disabled')) return var $this = $(this)
$parent = getParent($this) e.preventDefault()
e.stopPropagation()
isActive = $parent.hasClass('open') if ($this.is('.disabled, :disabled')) return
if (!isActive || (isActive && e.keyCode == 27)) { var $parent = getParent($this)
if (e.which == 27) $parent.find(toggle).focus() var isActive = $parent.hasClass('open')
return $this.click()
}
$items = $('[role=menu] li:not(.divider):visible a', $parent) if (!isActive || (isActive && e.keyCode == 27)) {
if (e.which == 27) $parent.find(toggle).focus()
return $this.click()
}
if (!$items.length) return var $items = $('[role=menu] li:not(.divider):visible a', $parent)
index = $items.index($items.filter(':focus')) if (!$items.length) return
if (e.keyCode == 38 && index > 0) index-- // up var index = $items.index($items.filter(':focus'))
if (e.keyCode == 40 && index < $items.length - 1) index++ // down
if (!~index) index = 0
$items if (e.keyCode == 38 && index > 0) index-- // up
.eq(index) if (e.keyCode == 40 && index < $items.length - 1) index++ // down
.focus() if (!~index) index=0
}
$items.eq(index).focus()
} }
function clearMenus() { function clearMenus() {
$(toggle).each(function () { $(backdrop).remove()
getParent($(this)).removeClass('open') $(toggle).each(function () { getParent($(this)).removeClass('open') })
})
} }
function getParent($this) { function getParent($this) {
var selector = $this.attr('data-target') var selector = $this.attr('data-target')
, $parent
if (!selector) { if (!selector) {
selector = $this.attr('href') selector = $this.attr('href')
selector = selector && /#/.test(selector) && selector.replace(/.*(?=#[^\s]*$)/, '') //strip for ie7 selector = selector && /#/.test(selector) && selector.replace(/.*(?=#[^\s]*$)/, '') //strip for ie7
} }
$parent = selector && $(selector) var $parent = selector && $(selector)
if (!$parent || !$parent.length) $parent = $this.parent()
return $parent return $parent && $parent.length ? $parent : $this.parent()
} }
/* DROPDOWN PLUGIN DEFINITION // DROPDOWN PLUGIN DEFINITION
* ========================== */ // ==========================
var old = $.fn.dropdown var old = $.fn.dropdown
$.fn.dropdown = function (option) { $.fn.dropdown = function (option) {
return this.each(function () { return this.each(function () {
var $this = $(this) var $this = $(this)
, data = $this.data('dropdown') var data = $this.data('dropdown')
if (!data) $this.data('dropdown', (data = new Dropdown(this))) if (!data) $this.data('dropdown', (data = new Dropdown(this)))
if (typeof option == 'string') data[option].call($this) if (typeof option == 'string') data[option].call($this)
}) })
...@@ -143,8 +121,8 @@ ...@@ -143,8 +121,8 @@
$.fn.dropdown.Constructor = Dropdown $.fn.dropdown.Constructor = Dropdown
/* DROPDOWN NO CONFLICT // DROPDOWN NO CONFLICT
* ==================== */ // ====================
$.fn.dropdown.noConflict = function () { $.fn.dropdown.noConflict = function () {
$.fn.dropdown = old $.fn.dropdown = old
...@@ -152,13 +130,12 @@ ...@@ -152,13 +130,12 @@
} }
/* APPLY TO STANDARD DROPDOWN ELEMENTS // APPLY TO STANDARD DROPDOWN ELEMENTS
* =================================== */ // ===================================
$(document) $(document)
.on('click.dropdown.data-api', clearMenus)
.on('click.dropdown.data-api', '.dropdown form', function (e) { e.stopPropagation() }) .on('click.dropdown.data-api', '.dropdown form', function (e) { e.stopPropagation() })
.on('click.dropdown-menu', function (e) { e.stopPropagation() })
.on('click.dropdown.data-api' , toggle, Dropdown.prototype.toggle) .on('click.dropdown.data-api' , toggle, Dropdown.prototype.toggle)
.on('keydown.dropdown.data-api', toggle + ', [role=menu]' , Dropdown.prototype.keydown) .on('keydown.dropdown.data-api', toggle + ', [role=menu]' , Dropdown.prototype.keydown)
......
...@@ -104,7 +104,7 @@ $(function () { ...@@ -104,7 +104,7 @@ $(function () {
.dropdown() .dropdown()
.click() .click()
ok(dropdown.parent('.dropdown').hasClass('open'), 'open class added on click') ok(dropdown.parent('.dropdown').hasClass('open'), 'open class added on click')
$('body').click() $('.dropdown-backdrop').click()
ok(!dropdown.parent('.dropdown').hasClass('open'), 'open class removed') ok(!dropdown.parent('.dropdown').hasClass('open'), 'open class removed')
dropdown.remove() dropdown.remove()
}) })
...@@ -136,13 +136,13 @@ $(function () { ...@@ -136,13 +136,13 @@ $(function () {
first.click() first.click()
ok(first.parents('.open').length == 1, 'open class added on click') ok(first.parents('.open').length == 1, 'open class added on click')
ok($('#qunit-fixture .open').length == 1, 'only one object is open') ok($('#qunit-fixture .open').length == 1, 'only one object is open')
$('body').click() $('.dropdown-backdrop').click()
ok($("#qunit-fixture .open").length === 0, 'open class removed') ok($("#qunit-fixture .open").length === 0, 'open class removed')
last.click() last.click()
ok(last.parent('.open').length == 1, 'open class added on click') ok(last.parent('.open').length == 1, 'open class added on click')
ok($('#qunit-fixture .open').length == 1, 'only one object is open') ok($('#qunit-fixture .open').length == 1, 'only one object is open')
$('body').click() $('.dropdown-backdrop').click()
ok($("#qunit-fixture .open").length === 0, 'open class removed') ok($("#qunit-fixture .open").length === 0, 'open class removed')
$("#qunit-fixture").html("") $("#qunit-fixture").html("")
......
...@@ -114,6 +114,18 @@ ...@@ -114,6 +114,18 @@
} }
} }
// Backdrop to catch body clicks on mobile, etc.
// ---------------------------
.dropdown-backdrop {
position: fixed;
left: 0;
right: 0;
bottom: 0;
top: 0;
z-index: @zindex-dropdown - 10;
}
// Right aligned dropdowns // Right aligned dropdowns
// --------------------------- // ---------------------------
.pull-right > .dropdown-menu { .pull-right > .dropdown-menu {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment