rename tabs to tab - clean up lots of api stuff make href acceptable target val

js/README.md

@@ -67,14 +67,14 @@ All events should have an infinitive and past participle form. The infinitive is
 Data attributes should take the following form:
 
 data-*(verb)* - defines main interaction
-data-target - defined on controller element (if element interacts with an element other than self)
+data-target || href^=# - defined on controller element (if element interacts with an element other than self)
 data-*(noun)* - defines options for element invocation
 
 examples:
 
     // control other targets
     data-toggle="modal" data-target="#foo"
-    data-toggle="view" data-target="#foo"
+    data-toggle="collapse" data-target="#foo" data-parent="#foo"
 
     // defined on element they control
     data-spy="scroll"

js/bootstrap-collapse.js

@@ -117,9 +117,9 @@
   $(function () {
     $('body').delegate('[data-toggle=collapse]', 'click.collapse.data-api', function ( e ) {
       var $this = $(this)
-        , target = $this.attr('data-target')
+        , target = $this.attr('data-target') || $this.attr('href')
         , option = $(target).data('collapse') ? 'toggle' : $this.data()
-      e.preventDefault()
+        e.preventDefault()
       $(target).collapse(option)
     })
   })

js/bootstrap-modal.js

@@ -192,7 +192,7 @@
   $(document).ready(function () {
     $('body').delegate('[data-toggle="modal"]', 'click.modal.data-api', function ( e ) {
       var $this = $(this)
-        , target = $this.attr('data-target')
+        , target = $this.attr('data-target') || $this.attr('href')
         , option = $(target).data('modal') ? 'toggle' : $this.data()
       e.preventDefault()
       $(target).modal(option)

js/bootstrap-scrollspy.js

@@ -28,7 +28,9 @@
     var process = $.proxy(this.process, this)
 
     this.$scrollElement = $(element).bind('scroll.scroll.data-api', process)
-    this.selector = (this.$scrollElement.attr('data-target') || '') + ' .nav li > a'
+    this.selector = (this.$scrollElement.attr('data-target')
+      || this.$scrollElement.attr('href')
+      || '') + ' .nav li > a'
     this.$body = $('body').delegate(this.selector, 'click.scroll.data-api', process)
 
     this.refresh()

js/bootstrap-tabs.js → js/bootstrap-tab.js

@@ -22,59 +22,81 @@
 
   "use strict"
 
-  function activate ( element, container ) {
-    container
-      .find('> .active')
-      .removeClass('active')
-      .find('> .dropdown-menu > .active')
-      .removeClass('active')
+ /* TAB CLASS DEFINITION
+  * ==================== */
 
-    element.addClass('active')
-
-    if ( element.parent('.dropdown-menu') ) {
-      element.closest('li.dropdown').addClass('active')
-    }
+  var Tab = function ( element ) {
+    this.element = $(element)
   }
 
-  function tab( e ) {
-    var $this = $(this)
-      , $ul = $this.closest('ul:not(.dropdown-menu)')
-      , href = $this.attr('href')
-      , previous
-      , $href
+  Tab.prototype = {
 
-    if ( /^#\w+/.test(href) ) {
-      e.preventDefault()
+    show: function () {
+      var $this = this.element
+        , $ul = $this.closest('ul:not(.dropdown-menu)')
+        , href = $this.attr('data-target') || $this.attr('href')
+        , previous
+        , $href
 
-      if ( $this.parent('li').hasClass('active') ) {
-        return
-      }
+      if ( $this.parent('li').hasClass('active') ) return
 
       previous = $ul.find('.active a').last()[0]
+
+      $this.trigger({
+        type: 'show'
+      , relatedTarget: previous
+      })
+
       $href = $(href)
 
-      activate($this.parent('li'), $ul)
-      activate($href, $href.parent())
+      this.activate($this.parent('li'), $ul)
+      this.activate($href, $href.parent())
 
       $this.trigger({
-        type: 'change'
+        type: 'shown'
       , relatedTarget: previous
       })
     }
+
+  , activate: function ( element, container ) {
+      container
+        .find('> .active')
+        .removeClass('active')
+        .find('> .dropdown-menu > .active')
+        .removeClass('active')
+
+      element.addClass('active')
+
+      if ( element.parent('.dropdown-menu') ) {
+        element.closest('li.dropdown').addClass('active')
+      }
+    }
   }
 
 
- /* TABS/PILLS PLUGIN DEFINITION
-  * ============================ */
+ /* TAB PLUGIN DEFINITION
+  * ===================== */
 
-  $.fn.tabs = $.fn.pills = function ( selector ) {
+  $.fn.tab = function (option) {
     return this.each(function () {
-      $(this).delegate(selector || '.tabs li > a, .pills > li > a', 'click', tab)
+      var $this = $(this)
+        , data = $this.data('tab')
+      if (!data) $this.data('tab', (data = new Tab(this)))
+      if (typeof option == 'string') data[option]()
     })
   }
 
+  $.fn.tab.Tab = Tab
+
+
+ /* TAB DATA-API
+  * ============ */
+
   $(document).ready(function () {
-    $('body').tabs('ul[data-tabs] li > a, ul[data-pills] > li > a')
+    $('body').delegate('[data-toggle="tab"], [data-toggle="pill"]', 'click.tab.data-api', function (e) {
+      e.preventDefault()
+      $(this).tab('show')
+    })
   })
 
 }( window.jQuery || window.ender )
\ No newline at end of file