Merge pull request #1346 from nobodyiam/fix-public-appnamespace-deleted-and-recreated

fix the situation when some public app namespace is deleted and recreated in another app

apollo-biz/src/main/java/com/ctrip/framework/apollo/biz/service/AppNamespaceService.java

@@ -131,6 +131,12 @@ public class AppNamespaceService {
     List<Cluster> clusters = clusterService.findParentClusters(appId);
 
     for (Cluster cluster : clusters) {
+
+      // in case there is some dirty data, e.g. public namespace deleted in other app and now created in this app
+      if (!namespaceService.isNamespaceUnique(appId, cluster.getName(), namespaceName)) {
+        continue;
+      }
+
       Namespace namespace = new Namespace();
       namespace.setClusterName(cluster.getName());
       namespace.setAppId(appId);

apollo-configservice/src/main/java/com/ctrip/framework/apollo/configservice/service/AppNamespaceServiceWithCache.java

@@ -247,7 +247,11 @@ public class AppNamespaceServiceWithCache implements InitializingBean {
       }
       appNamespaceCache.remove(assembleAppNamespaceKey(deleted));
       if (deleted.isPublic()) {
-        publicAppNamespaceCache.remove(deleted.getName());
+        AppNamespace publicAppNamespace = publicAppNamespaceCache.get(deleted.getName());
+        // in case there is some dirty data, e.g. public namespace deleted in some app and now created in another app
+        if (publicAppNamespace == deleted) {
+          publicAppNamespaceCache.remove(deleted.getName());
+        }
       }
       logger.info("Found AppNamespace deleted, {}", deleted);
     }