Merge pull request #12177 from feroozkhanchintu/master

Refactored Long Method

src/main/java/org/b3log/solo/processor/FeedProcessor.java

@@ -159,55 +159,50 @@ public class FeedProcessor {
             final boolean isFullContent = "fullContent".equals(preference.getString(Option.ID_C_FEED_OUTPUT_MODE));
 
             for (int i = 0; i < articles.length(); i++) {
+                Entry entry = getEntry(hasMultipleUsers, authorName, articles, isFullContent, i);
+                feed.addEntry(entry);
+            }
+
+            renderer.setContent(feed.toString());
+        } catch (final Exception e) {
+            LOGGER.log(Level.ERROR, "Get blog article feed error", e);
+
+            try {
+                context.getResponse().sendError(HttpServletResponse.SC_SERVICE_UNAVAILABLE);
+            } catch (final IOException ex) {
+                throw new RuntimeException(ex);
+            }
+        }
+    }
+
+    private Entry getEntry(final boolean hasMultipleUsers, String authorName, final JSONArray articles,
+            final boolean isFullContent, int i)
+            throws org.json.JSONException, org.b3log.latke.service.ServiceException {
         final JSONObject article = articles.getJSONObject(i);
         final Entry entry = new Entry();
-
-                feed.addEntry(entry);
         final String title = StringEscapeUtils.escapeXml(article.getString(Article.ARTICLE_TITLE));
-
         entry.setTitle(title);
-                final String summary = isFullContent
-                        ? StringEscapeUtils.escapeXml(article.getString(Article.ARTICLE_CONTENT))
+        final String summary = isFullContent ? StringEscapeUtils.escapeXml(article.getString(Article.ARTICLE_CONTENT))
                 : StringEscapeUtils.escapeXml(article.optString(Article.ARTICLE_ABSTRACT));
-
         entry.setSummary(summary);
         final Date updated = (Date) article.get(Article.ARTICLE_UPDATE_DATE);
-
         entry.setUpdated(updated);
-
         final String link = Latkes.getServePath() + article.getString(Article.ARTICLE_PERMALINK);
-
         entry.setLink(link);
         entry.setId(link);
-
         if (hasMultipleUsers) {
             authorName = StringEscapeUtils.escapeXml(articleQueryService.getAuthor(article).getString(User.USER_NAME));
         }
         entry.setAuthor(authorName);
-
         final String tagsString = article.getString(Article.ARTICLE_TAGS_REF);
         final String[] tagStrings = tagsString.split(",");
-
         for (int j = 0; j < tagStrings.length; j++) {
             final Category catetory = new Category();
-
             entry.addCatetory(catetory);
             final String tag = tagStrings[j];
-
             catetory.setTerm(tag);
         }
-            }
-
-            renderer.setContent(feed.toString());
-        } catch (final Exception e) {
-            LOGGER.log(Level.ERROR, "Get blog article feed error", e);
-
-            try {
-                context.getResponse().sendError(HttpServletResponse.SC_SERVICE_UNAVAILABLE);
-            } catch (final IOException ex) {
-                throw new RuntimeException(ex);
-            }
-        }
+        return entry;
     }
 
     /**
@@ -296,53 +291,49 @@ public class FeedProcessor {
             final boolean isFullContent = "fullContent".equals(preference.getString(Option.ID_C_FEED_OUTPUT_MODE));
 
             for (int i = 0; i < articles.size(); i++) {
+                Entry entry = getEntryForArticle(articles, hasMultipleUsers, authorName, isFullContent, i);
+                feed.addEntry(entry);
+            }
+
+            renderer.setContent(feed.toString());
+        } catch (final Exception e) {
+            LOGGER.log(Level.ERROR, "Get tag article feed error", e);
+
+            try {
+                context.getResponse().sendError(HttpServletResponse.SC_SERVICE_UNAVAILABLE);
+            } catch (final IOException ex) {
+                throw new RuntimeException(ex);
+            }
+        }
+    }
+
+    private Entry getEntryForArticle(final List<JSONObject> articles, final boolean hasMultipleUsers, String authorName,
+            final boolean isFullContent, int i)
+            throws org.json.JSONException, org.b3log.latke.service.ServiceException {
         final JSONObject article = articles.get(i);
         final Entry entry = new Entry();
-
-                feed.addEntry(entry);
         final String title = StringEscapeUtils.escapeXml(article.getString(Article.ARTICLE_TITLE));
-
         entry.setTitle(title);
-                final String summary = isFullContent
-                        ? StringEscapeUtils.escapeXml(article.getString(Article.ARTICLE_CONTENT))
+        final String summary = isFullContent ? StringEscapeUtils.escapeXml(article.getString(Article.ARTICLE_CONTENT))
                 : StringEscapeUtils.escapeXml(article.optString(Article.ARTICLE_ABSTRACT));
-
         entry.setSummary(summary);
         final Date updated = (Date) article.get(Article.ARTICLE_UPDATE_DATE);
-
         entry.setUpdated(updated);
         final String link = Latkes.getServePath() + article.getString(Article.ARTICLE_PERMALINK);
-
         entry.setLink(link);
         entry.setId(link);
-
         if (hasMultipleUsers) {
             authorName = StringEscapeUtils.escapeXml(articleQueryService.getAuthor(article).getString(User.USER_NAME));
         }
-
         entry.setAuthor(authorName);
-
         final String tagsString = article.getString(Article.ARTICLE_TAGS_REF);
         final String[] tagStrings = tagsString.split(",");
-
         for (int j = 0; j < tagStrings.length; j++) {
             final Category catetory = new Category();
-
             entry.addCatetory(catetory);
             catetory.setTerm(tagStrings[j]);
         }
-            }
-
-            renderer.setContent(feed.toString());
-        } catch (final Exception e) {
-            LOGGER.log(Level.ERROR, "Get tag article feed error", e);
-
-            try {
-                context.getResponse().sendError(HttpServletResponse.SC_SERVICE_UNAVAILABLE);
-            } catch (final IOException ex) {
-                throw new RuntimeException(ex);
-            }
-        }
+        return entry;
     }
 
     /**
@@ -403,57 +394,52 @@ public class FeedProcessor {
             final boolean isFullContent = "fullContent".equals(preference.getString(Option.ID_C_FEED_OUTPUT_MODE));
 
             for (int i = 0; i < articles.length(); i++) {
+                Item item = getItem(articles, hasMultipleUsers, authorName, isFullContent, i);
+                channel.addItem(item);
+            }
+
+            renderer.setContent(channel.toString());
+        } catch (final Exception e) {
+            LOGGER.log(Level.ERROR, "Get blog article rss error", e);
+
+            try {
+                context.getResponse().sendError(HttpServletResponse.SC_SERVICE_UNAVAILABLE);
+            } catch (final IOException ex) {
+                throw new RuntimeException(ex);
+            }
+        }
+    }
+
+    private Item getItem(final JSONArray articles, final boolean hasMultipleUsers, String authorName,
+            final boolean isFullContent, int i)
+            throws org.json.JSONException, org.b3log.latke.service.ServiceException {
         final JSONObject article = articles.getJSONObject(i);
         final Item item = new Item();
-
-                channel.addItem(item);
         final String title = StringEscapeUtils.escapeXml(article.getString(Article.ARTICLE_TITLE));
-
         item.setTitle(title);
         final String description = isFullContent
                 ? StringEscapeUtils.escapeXml(article.getString(Article.ARTICLE_CONTENT))
                 : StringEscapeUtils.escapeXml(article.optString(Article.ARTICLE_ABSTRACT));
-
         item.setDescription(description);
         final Date pubDate = (Date) article.get(Article.ARTICLE_UPDATE_DATE);
-
         item.setPubDate(pubDate);
         final String link = Latkes.getServePath() + article.getString(Article.ARTICLE_PERMALINK);
-
         item.setLink(link);
         item.setGUID(link);
-
         final String authorEmail = article.getString(Article.ARTICLE_AUTHOR_EMAIL);
-
         if (hasMultipleUsers) {
             authorName = StringEscapeUtils.escapeXml(articleQueryService.getAuthor(article).getString(User.USER_NAME));
         }
-
         item.setAuthor(authorEmail + "(" + authorName + ")");
-
         final String tagsString = article.getString(Article.ARTICLE_TAGS_REF);
         final String[] tagStrings = tagsString.split(",");
-
         for (int j = 0; j < tagStrings.length; j++) {
             final org.b3log.solo.model.feed.rss.Category catetory = new org.b3log.solo.model.feed.rss.Category();
-
             item.addCatetory(catetory);
             final String tag = tagStrings[j];
-
             catetory.setTerm(tag);
         }
-            }
-
-            renderer.setContent(channel.toString());
-        } catch (final Exception e) {
-            LOGGER.log(Level.ERROR, "Get blog article rss error", e);
-
-            try {
-                context.getResponse().sendError(HttpServletResponse.SC_SERVICE_UNAVAILABLE);
-            } catch (final IOException ex) {
-                throw new RuntimeException(ex);
-            }
-        }
+        return item;
     }
 
     /**
@@ -547,54 +533,50 @@ public class FeedProcessor {
             final boolean isFullContent = "fullContent".equals(preference.getString(Option.ID_C_FEED_OUTPUT_MODE));
 
             for (int i = 0; i < articles.size(); i++) {
+                Item item = getItemForArticles(articles, hasMultipleUsers, authorName, isFullContent, i);
+                channel.addItem(item);
+            }
+
+            renderer.setContent(channel.toString());
+        } catch (final Exception e) {
+            LOGGER.log(Level.ERROR, "Get tag article rss error", e);
+
+            try {
+                context.getResponse().sendError(HttpServletResponse.SC_SERVICE_UNAVAILABLE);
+            } catch (final IOException ex) {
+                throw new RuntimeException(ex);
+            }
+        }
+    }
+
+    private Item getItemForArticles(final List<JSONObject> articles, final boolean hasMultipleUsers, String authorName,
+            final boolean isFullContent, int i)
+            throws org.json.JSONException, org.b3log.latke.service.ServiceException {
         final JSONObject article = articles.get(i);
         final Item item = new Item();
-
-                channel.addItem(item);
         final String title = StringEscapeUtils.escapeXml(article.getString(Article.ARTICLE_TITLE));
-
         item.setTitle(title);
         final String description = isFullContent
                 ? StringEscapeUtils.escapeXml(article.getString(Article.ARTICLE_CONTENT))
                 : StringEscapeUtils.escapeXml(article.optString(Article.ARTICLE_ABSTRACT));
-
         item.setDescription(description);
         final Date pubDate = (Date) article.get(Article.ARTICLE_UPDATE_DATE);
-
         item.setPubDate(pubDate);
         final String link = Latkes.getServePath() + article.getString(Article.ARTICLE_PERMALINK);
-
         item.setLink(link);
         item.setGUID(link);
-
         final String authorEmail = article.getString(Article.ARTICLE_AUTHOR_EMAIL);
-
         if (hasMultipleUsers) {
             authorName = StringEscapeUtils.escapeXml(articleQueryService.getAuthor(article).getString(User.USER_NAME));
         }
-
         item.setAuthor(authorEmail + "(" + authorName + ")");
-
         final String tagsString = article.getString(Article.ARTICLE_TAGS_REF);
         final String[] tagStrings = tagsString.split(",");
-
         for (int j = 0; j < tagStrings.length; j++) {
             final org.b3log.solo.model.feed.rss.Category catetory = new org.b3log.solo.model.feed.rss.Category();
-
             item.addCatetory(catetory);
             catetory.setTerm(tagStrings[j]);
         }
-            }
-
-            renderer.setContent(channel.toString());
-        } catch (final Exception e) {
-            LOGGER.log(Level.ERROR, "Get tag article rss error", e);
-
-            try {
-                context.getResponse().sendError(HttpServletResponse.SC_SERVICE_UNAVAILABLE);
-            } catch (final IOException ex) {
-                throw new RuntimeException(ex);
-            }
-        }
+        return item;
     }
 }