Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
B
bootstrap
Project overview
Project overview
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Administrator
bootstrap
Commits
1d55ada5
Commit
1d55ada5
authored
Nov 12, 2014
by
Heinrich Fenkart
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Dropdown: ignore keydown events coming from `input`s and `textarea`s
Fixes #15084.
parent
2006a435
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
42 additions
and
1 deletion
+42
-1
js/dropdown.js
js/dropdown.js
+1
-1
js/tests/unit/dropdown.js
js/tests/unit/dropdown.js
+41
-0
No files found.
js/dropdown.js
View file @
1d55ada5
...
@@ -55,7 +55,7 @@
...
@@ -55,7 +55,7 @@
}
}
Dropdown
.
prototype
.
keydown
=
function
(
e
)
{
Dropdown
.
prototype
.
keydown
=
function
(
e
)
{
if
(
!
/
(
38|40|27|32
)
/
.
test
(
e
.
which
))
return
if
(
!
/
(
38|40|27|32
)
/
.
test
(
e
.
which
)
||
/input|textarea/i
.
test
(
e
.
target
.
tagName
)
)
return
var
$this
=
$
(
this
)
var
$this
=
$
(
this
)
...
...
js/tests/unit/dropdown.js
View file @
1d55ada5
...
@@ -224,4 +224,45 @@ $(function () {
...
@@ -224,4 +224,45 @@ $(function () {
$
(
document
.
body
).
click
()
$
(
document
.
body
).
click
()
})
})
test
(
'
should ignore keyboard events within <input>s and <textarea>s
'
,
function
()
{
stop
()
var
dropdownHTML
=
'
<ul class="tabs">
'
+
'
<li class="dropdown">
'
+
'
<a href="#" class="dropdown-toggle" data-toggle="dropdown">Dropdown</a>
'
+
'
<ul class="dropdown-menu" role="menu">
'
+
'
<li><a href="#">Secondary link</a></li>
'
+
'
<li><a href="#">Something else here</a></li>
'
+
'
<li class="divider"/>
'
+
'
<li><a href="#">Another link</a></li>
'
+
'
<li><input type="text" id="input"></li>
'
+
'
<li><textarea id="textarea"/></li>
'
+
'
</ul>
'
+
'
</li>
'
+
'
</ul>
'
var
$dropdown
=
$
(
dropdownHTML
)
.
appendTo
(
'
#qunit-fixture
'
)
.
find
(
'
[data-toggle="dropdown"]
'
)
.
bootstrapDropdown
()
var
$input
=
$
(
'
#input
'
)
var
$textarea
=
$
(
'
#textarea
'
)
$dropdown
.
parent
(
'
.dropdown
'
)
.
on
(
'
shown.bs.dropdown
'
,
function
()
{
ok
(
true
,
'
shown was fired
'
)
$input
.
focus
().
trigger
(
$
.
Event
(
'
keydown
'
,
{
which
:
38
}))
ok
(
$
(
document
.
activeElement
).
is
(
$input
),
'
input still focused
'
)
$textarea
.
focus
().
trigger
(
$
.
Event
(
'
keydown
'
,
{
which
:
38
}))
ok
(
$
(
document
.
activeElement
).
is
(
$textarea
),
'
textarea still focused
'
)
start
()
})
$dropdown
.
click
()
})
})
})
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment