Skip to content

A
apollo
Commit f417ef3e authored by Zhuohao Li's avatar Zhuohao Li Committed by Jason Song
Browse files
Options

Fixed an issue with openapi item comment being too long (#2849)

parent 4ce3d70c
Show whitespace changes
Inline Side-by-side
Showing with 8 additions and 0 deletions
apollo-portal/src/main/java/com/ctrip/framework/apollo/openapi/v1/controller/ItemController.java
View file @ f417ef3e
...@@ -60,6 +60,10 @@ public class ItemController { ...@@ -60,6 +60,10 @@ public class ItemController {
throw new BadRequestException("User " + item.getDataChangeCreatedBy() + " doesn't exist!"); throw new BadRequestException("User " + item.getDataChangeCreatedBy() + " doesn't exist!");
} }
if(!StringUtils.isEmpty(item.getComment()) && item.getComment().length() > 64){
throw new BadRequestException("Comment length should not exceed 64 characters");
}
ItemDTO toCreate = OpenApiBeanUtils.transformToItemDTO(item); ItemDTO toCreate = OpenApiBeanUtils.transformToItemDTO(item);
//protect //protect
...@@ -93,6 +97,10 @@ public class ItemController { ...@@ -93,6 +97,10 @@ public class ItemController {
throw new BadRequestException("user(dataChangeLastModifiedBy) not exists"); throw new BadRequestException("user(dataChangeLastModifiedBy) not exists");
} }
if(!StringUtils.isEmpty(item.getComment()) && item.getComment().length() > 64){
throw new BadRequestException("Comment length should not exceed 64 characters");
}
try { try {
ItemDTO toUpdateItem = itemService ItemDTO toUpdateItem = itemService
.loadItem(Env.fromString(env), appId, clusterName, namespaceName, item.getKey()); .loadItem(Env.fromString(env), appId, clusterName, namespaceName, item.getKey());
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment