Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
A
apollo
Project overview
Project overview
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Administrator
apollo
Commits
df1c73b7
Commit
df1c73b7
authored
Mar 29, 2016
by
Jason Song
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Change appid data type to String
parent
29858d70
Changes
44
Show whitespace changes
Inline
Side-by-side
Showing
44 changed files
with
151 additions
and
148 deletions
+151
-148
apollo-adminservice/src/main/java/com/ctrip/apollo/adminservice/controller/ClusterController.java
...rip/apollo/adminservice/controller/ClusterController.java
+1
-1
apollo-adminservice/src/main/java/com/ctrip/apollo/adminservice/controller/VersionController.java
...rip/apollo/adminservice/controller/VersionController.java
+1
-1
apollo-biz/src/main/java/com/ctrip/apollo/biz/entity/Cluster.java
...iz/src/main/java/com/ctrip/apollo/biz/entity/Cluster.java
+3
-3
apollo-biz/src/main/java/com/ctrip/apollo/biz/entity/ConfigItem.java
...src/main/java/com/ctrip/apollo/biz/entity/ConfigItem.java
+3
-3
apollo-biz/src/main/java/com/ctrip/apollo/biz/entity/Release.java
...iz/src/main/java/com/ctrip/apollo/biz/entity/Release.java
+3
-3
apollo-biz/src/main/java/com/ctrip/apollo/biz/entity/Version.java
...iz/src/main/java/com/ctrip/apollo/biz/entity/Version.java
+3
-3
apollo-biz/src/main/java/com/ctrip/apollo/biz/repository/ClusterRepository.java
...va/com/ctrip/apollo/biz/repository/ClusterRepository.java
+1
-1
apollo-biz/src/main/java/com/ctrip/apollo/biz/repository/VersionRepository.java
...va/com/ctrip/apollo/biz/repository/VersionRepository.java
+2
-2
apollo-biz/src/main/java/com/ctrip/apollo/biz/service/AdminConfigService.java
...java/com/ctrip/apollo/biz/service/AdminConfigService.java
+2
-2
apollo-biz/src/main/java/com/ctrip/apollo/biz/service/ConfigService.java
...main/java/com/ctrip/apollo/biz/service/ConfigService.java
+2
-2
apollo-biz/src/main/java/com/ctrip/apollo/biz/service/impl/AdminConfigServiceImpl.java
...ctrip/apollo/biz/service/impl/AdminConfigServiceImpl.java
+6
-4
apollo-biz/src/main/java/com/ctrip/apollo/biz/service/impl/ConfigServiceImpl.java
.../com/ctrip/apollo/biz/service/impl/ConfigServiceImpl.java
+2
-2
apollo-biz/src/test/java/com/ctrip/apollo/biz/service/impl/ConfigServiceImplTest.java
.../ctrip/apollo/biz/service/impl/ConfigServiceImplTest.java
+4
-4
apollo-client/src/main/java/com/ctrip/apollo/client/env/ClientEnvironment.java
...n/java/com/ctrip/apollo/client/env/ClientEnvironment.java
+1
-1
apollo-client/src/main/java/com/ctrip/apollo/client/loader/ConfigLoaderManager.java
...a/com/ctrip/apollo/client/loader/ConfigLoaderManager.java
+1
-1
apollo-client/src/main/java/com/ctrip/apollo/client/loader/impl/RemoteConfigLoader.java
...m/ctrip/apollo/client/loader/impl/RemoteConfigLoader.java
+1
-1
apollo-client/src/main/java/com/ctrip/apollo/client/model/ApolloRegistry.java
...in/java/com/ctrip/apollo/client/model/ApolloRegistry.java
+3
-3
apollo-client/src/main/java/com/ctrip/apollo/client/util/ConfigUtil.java
...rc/main/java/com/ctrip/apollo/client/util/ConfigUtil.java
+1
-1
apollo-client/src/test/java/com/ctrip/apollo/client/loader/ConfigLoaderManagerTest.java
...m/ctrip/apollo/client/loader/ConfigLoaderManagerTest.java
+8
-8
apollo-client/src/test/java/com/ctrip/apollo/client/loader/impl/RemoteConfigLoaderTest.java
...rip/apollo/client/loader/impl/RemoteConfigLoaderTest.java
+5
-5
apollo-client/src/test/java/com/ctrip/apollo/client/util/ConfigUtilTest.java
...est/java/com/ctrip/apollo/client/util/ConfigUtilTest.java
+1
-1
apollo-configservice/src/main/java/com/ctrip/apollo/configservice/controller/ConfigController.java
...rip/apollo/configservice/controller/ConfigController.java
+2
-2
apollo-configservice/src/test/java/com/ctrip/apollo/configservice/controller/ConfigControllerTest.java
...apollo/configservice/controller/ConfigControllerTest.java
+4
-4
apollo-core/src/main/java/com/ctrip/apollo/core/dto/ApolloConfig.java
...src/main/java/com/ctrip/apollo/core/dto/ApolloConfig.java
+3
-3
apollo-core/src/main/java/com/ctrip/apollo/core/dto/ClusterDTO.java
...e/src/main/java/com/ctrip/apollo/core/dto/ClusterDTO.java
+3
-3
apollo-core/src/main/java/com/ctrip/apollo/core/dto/ConfigItemDTO.java
...rc/main/java/com/ctrip/apollo/core/dto/ConfigItemDTO.java
+3
-3
apollo-core/src/main/java/com/ctrip/apollo/core/dto/VersionDTO.java
...e/src/main/java/com/ctrip/apollo/core/dto/VersionDTO.java
+3
-3
apollo-portal/src/main/java/com/ctrip/apollo/portal/api/AdminServiceAPI.java
...ain/java/com/ctrip/apollo/portal/api/AdminServiceAPI.java
+6
-4
apollo-portal/src/main/java/com/ctrip/apollo/portal/controller/AppController.java
...ava/com/ctrip/apollo/portal/controller/AppController.java
+1
-1
apollo-portal/src/main/java/com/ctrip/apollo/portal/controller/ConfigController.java
.../com/ctrip/apollo/portal/controller/ConfigController.java
+4
-2
apollo-portal/src/main/java/com/ctrip/apollo/portal/controller/VersionController.java
...com/ctrip/apollo/portal/controller/VersionController.java
+1
-1
apollo-portal/src/main/java/com/ctrip/apollo/portal/entity/App.java
...tal/src/main/java/com/ctrip/apollo/portal/entity/App.java
+3
-3
apollo-portal/src/main/java/com/ctrip/apollo/portal/entity/AppConfigVO.java
...main/java/com/ctrip/apollo/portal/entity/AppConfigVO.java
+7
-7
apollo-portal/src/main/java/com/ctrip/apollo/portal/entity/Privilege.java
...c/main/java/com/ctrip/apollo/portal/entity/Privilege.java
+3
-3
apollo-portal/src/main/java/com/ctrip/apollo/portal/repository/AppRepository.java
...ava/com/ctrip/apollo/portal/repository/AppRepository.java
+1
-1
apollo-portal/src/main/java/com/ctrip/apollo/portal/repository/PrivilegeRepository.java
...m/ctrip/apollo/portal/repository/PrivilegeRepository.java
+3
-3
apollo-portal/src/main/java/com/ctrip/apollo/portal/service/AppService.java
...main/java/com/ctrip/apollo/portal/service/AppService.java
+1
-1
apollo-portal/src/main/java/com/ctrip/apollo/portal/service/ConfigService.java
...n/java/com/ctrip/apollo/portal/service/ConfigService.java
+22
-20
apollo-portal/src/main/java/com/ctrip/apollo/portal/service/PrivilegeService.java
...ava/com/ctrip/apollo/portal/service/PrivilegeService.java
+4
-4
apollo-portal/src/main/java/com/ctrip/apollo/portal/service/VersionService.java
.../java/com/ctrip/apollo/portal/service/VersionService.java
+1
-1
apollo-portal/src/test/java/com/ctrip/apollo/portal/controller/AppControllerTest.java
...com/ctrip/apollo/portal/controller/AppControllerTest.java
+3
-3
apollo-portal/src/test/java/com/ctrip/apollo/portal/repository/AppRepositoryTest.java
...com/ctrip/apollo/portal/repository/AppRepositoryTest.java
+1
-1
apollo-portal/src/test/java/com/ctrip/apollo/portal/service/ConfigServiceTest.java
...va/com/ctrip/apollo/portal/service/ConfigServiceTest.java
+16
-21
apollo-portal/src/test/java/com/ctrip/apollo/portal/service/PrivilegeServiceTest.java
...com/ctrip/apollo/portal/service/PrivilegeServiceTest.java
+2
-2
No files found.
apollo-adminservice/src/main/java/com/ctrip/apollo/adminservice/controller/ClusterController.java
View file @
df1c73b7
...
@@ -18,7 +18,7 @@ public class ClusterController {
...
@@ -18,7 +18,7 @@ public class ClusterController {
private
AdminConfigService
adminConfigService
;
private
AdminConfigService
adminConfigService
;
@RequestMapping
(
"/app/{appId}"
)
@RequestMapping
(
"/app/{appId}"
)
public
List
<
ClusterDTO
>
findClustersByApp
(
@PathVariable
lo
ng
appId
)
{
public
List
<
ClusterDTO
>
findClustersByApp
(
@PathVariable
Stri
ng
appId
)
{
return
adminConfigService
.
findClustersByApp
(
appId
);
return
adminConfigService
.
findClustersByApp
(
appId
);
}
}
}
}
apollo-adminservice/src/main/java/com/ctrip/apollo/adminservice/controller/VersionController.java
View file @
df1c73b7
...
@@ -18,7 +18,7 @@ public class VersionController {
...
@@ -18,7 +18,7 @@ public class VersionController {
private
AdminConfigService
adminConfigService
;
private
AdminConfigService
adminConfigService
;
@RequestMapping
(
"/app/{appId}"
)
@RequestMapping
(
"/app/{appId}"
)
public
List
<
VersionDTO
>
versions
(
@PathVariable
lo
ng
appId
)
{
public
List
<
VersionDTO
>
versions
(
@PathVariable
Stri
ng
appId
)
{
return
adminConfigService
.
findVersionsByApp
(
appId
);
return
adminConfigService
.
findVersionsByApp
(
appId
);
}
}
...
...
apollo-biz/src/main/java/com/ctrip/apollo/biz/entity/Cluster.java
View file @
df1c73b7
...
@@ -25,7 +25,7 @@ public class Cluster {
...
@@ -25,7 +25,7 @@ public class Cluster {
private
String
name
;
private
String
name
;
@Column
(
nullable
=
false
)
@Column
(
nullable
=
false
)
private
lo
ng
appId
;
private
Stri
ng
appId
;
private
boolean
isDeleted
;
private
boolean
isDeleted
;
...
@@ -48,11 +48,11 @@ public class Cluster {
...
@@ -48,11 +48,11 @@ public class Cluster {
this
.
name
=
name
;
this
.
name
=
name
;
}
}
public
lo
ng
getAppId
()
{
public
Stri
ng
getAppId
()
{
return
appId
;
return
appId
;
}
}
public
void
setAppId
(
lo
ng
appId
)
{
public
void
setAppId
(
Stri
ng
appId
)
{
this
.
appId
=
appId
;
this
.
appId
=
appId
;
}
}
...
...
apollo-biz/src/main/java/com/ctrip/apollo/biz/entity/ConfigItem.java
View file @
df1c73b7
...
@@ -26,7 +26,7 @@ public class ConfigItem {
...
@@ -26,7 +26,7 @@ public class ConfigItem {
private
String
clusterName
;
private
String
clusterName
;
@Column
(
nullable
=
false
)
@Column
(
nullable
=
false
)
private
lo
ng
appId
;
private
Stri
ng
appId
;
@Column
(
nullable
=
false
)
@Column
(
nullable
=
false
)
private
String
key
;
private
String
key
;
...
@@ -76,11 +76,11 @@ public class ConfigItem {
...
@@ -76,11 +76,11 @@ public class ConfigItem {
this
.
clusterName
=
clusterName
;
this
.
clusterName
=
clusterName
;
}
}
public
lo
ng
getAppId
()
{
public
Stri
ng
getAppId
()
{
return
appId
;
return
appId
;
}
}
public
void
setAppId
(
lo
ng
appId
)
{
public
void
setAppId
(
Stri
ng
appId
)
{
this
.
appId
=
appId
;
this
.
appId
=
appId
;
}
}
...
...
apollo-biz/src/main/java/com/ctrip/apollo/biz/entity/Release.java
View file @
df1c73b7
...
@@ -19,7 +19,7 @@ public class Release {
...
@@ -19,7 +19,7 @@ public class Release {
private
long
id
;
private
long
id
;
private
String
name
;
private
String
name
;
private
lo
ng
appId
;
private
Stri
ng
appId
;
private
String
comment
;
private
String
comment
;
private
boolean
isDeleted
;
private
boolean
isDeleted
;
...
@@ -42,11 +42,11 @@ public class Release {
...
@@ -42,11 +42,11 @@ public class Release {
this
.
name
=
name
;
this
.
name
=
name
;
}
}
public
lo
ng
getAppId
()
{
public
Stri
ng
getAppId
()
{
return
appId
;
return
appId
;
}
}
public
void
setAppId
(
lo
ng
appId
)
{
public
void
setAppId
(
Stri
ng
appId
)
{
this
.
appId
=
appId
;
this
.
appId
=
appId
;
}
}
...
...
apollo-biz/src/main/java/com/ctrip/apollo/biz/entity/Version.java
View file @
df1c73b7
...
@@ -23,7 +23,7 @@ public class Version {
...
@@ -23,7 +23,7 @@ public class Version {
private
String
name
;
private
String
name
;
@Column
(
nullable
=
false
)
@Column
(
nullable
=
false
)
private
lo
ng
appId
;
private
Stri
ng
appId
;
@Column
(
nullable
=
false
)
@Column
(
nullable
=
false
)
private
long
releaseId
;
private
long
releaseId
;
...
@@ -50,11 +50,11 @@ public class Version {
...
@@ -50,11 +50,11 @@ public class Version {
this
.
name
=
name
;
this
.
name
=
name
;
}
}
public
lo
ng
getAppId
()
{
public
Stri
ng
getAppId
()
{
return
appId
;
return
appId
;
}
}
public
void
setAppId
(
lo
ng
appId
)
{
public
void
setAppId
(
Stri
ng
appId
)
{
this
.
appId
=
appId
;
this
.
appId
=
appId
;
}
}
...
...
apollo-biz/src/main/java/com/ctrip/apollo/biz/repository/ClusterRepository.java
View file @
df1c73b7
...
@@ -9,6 +9,6 @@ import java.util.List;
...
@@ -9,6 +9,6 @@ import java.util.List;
public
interface
ClusterRepository
extends
PagingAndSortingRepository
<
Cluster
,
Long
>
{
public
interface
ClusterRepository
extends
PagingAndSortingRepository
<
Cluster
,
Long
>
{
List
<
Cluster
>
findByAppId
(
lo
ng
appId
);
List
<
Cluster
>
findByAppId
(
Stri
ng
appId
);
}
}
apollo-biz/src/main/java/com/ctrip/apollo/biz/repository/VersionRepository.java
View file @
df1c73b7
...
@@ -10,9 +10,9 @@ import java.util.List;
...
@@ -10,9 +10,9 @@ import java.util.List;
* @author Jason Song(song_s@ctrip.com)
* @author Jason Song(song_s@ctrip.com)
*/
*/
public
interface
VersionRepository
extends
PagingAndSortingRepository
<
Version
,
Long
>
{
public
interface
VersionRepository
extends
PagingAndSortingRepository
<
Version
,
Long
>
{
Version
findByAppIdAndName
(
lo
ng
appId
,
String
name
);
Version
findByAppIdAndName
(
Stri
ng
appId
,
String
name
);
Version
findById
(
long
id
);
Version
findById
(
long
id
);
List
<
Version
>
findByAppId
(
lo
ng
appId
);
List
<
Version
>
findByAppId
(
Stri
ng
appId
);
}
}
apollo-biz/src/main/java/com/ctrip/apollo/biz/service/AdminConfigService.java
View file @
df1c73b7
...
@@ -14,11 +14,11 @@ public interface AdminConfigService {
...
@@ -14,11 +14,11 @@ public interface AdminConfigService {
List
<
ReleaseSnapshotDTO
>
findReleaseSnapshotByReleaseId
(
long
releaseId
);
List
<
ReleaseSnapshotDTO
>
findReleaseSnapshotByReleaseId
(
long
releaseId
);
List
<
VersionDTO
>
findVersionsByApp
(
lo
ng
appId
);
List
<
VersionDTO
>
findVersionsByApp
(
Stri
ng
appId
);
VersionDTO
loadVersionById
(
long
versionId
);
VersionDTO
loadVersionById
(
long
versionId
);
List
<
ClusterDTO
>
findClustersByApp
(
lo
ng
appId
);
List
<
ClusterDTO
>
findClustersByApp
(
Stri
ng
appId
);
List
<
ConfigItemDTO
>
findConfigItemsByClusters
(
List
<
Long
>
clusterIds
);
List
<
ConfigItemDTO
>
findConfigItemsByClusters
(
List
<
Long
>
clusterIds
);
...
...
apollo-biz/src/main/java/com/ctrip/apollo/biz/service/ConfigService.java
View file @
df1c73b7
...
@@ -12,12 +12,12 @@ public interface ConfigService {
...
@@ -12,12 +12,12 @@ public interface ConfigService {
/**
/**
* Load configuration from database
* Load configuration from database
*/
*/
ApolloConfig
loadConfig
(
lo
ng
appId
,
String
clusterName
,
String
versionName
);
ApolloConfig
loadConfig
(
Stri
ng
appId
,
String
clusterName
,
String
versionName
);
/**
/**
* Load Version by appId and versionName from database
* Load Version by appId and versionName from database
*/
*/
Version
loadVersionByAppIdAndVersionName
(
lo
ng
appId
,
String
versionName
);
Version
loadVersionByAppIdAndVersionName
(
Stri
ng
appId
,
String
versionName
);
/**
/**
* Load Config by version and clusterName from database
* Load Config by version and clusterName from database
...
...
apollo-biz/src/main/java/com/ctrip/apollo/biz/service/impl/AdminConfigServiceImpl.java
View file @
df1c73b7
package
com
.
ctrip
.
apollo
.
biz
.
service
.
impl
;
package
com
.
ctrip
.
apollo
.
biz
.
service
.
impl
;
import
com.google.common.base.Strings
;
import
com.ctrip.apollo.biz.entity.Cluster
;
import
com.ctrip.apollo.biz.entity.Cluster
;
import
com.ctrip.apollo.biz.entity.ConfigItem
;
import
com.ctrip.apollo.biz.entity.ConfigItem
;
import
com.ctrip.apollo.biz.entity.ReleaseSnapshot
;
import
com.ctrip.apollo.biz.entity.ReleaseSnapshot
;
...
@@ -50,8 +52,8 @@ public class AdminConfigServiceImpl implements AdminConfigService {
...
@@ -50,8 +52,8 @@ public class AdminConfigServiceImpl implements AdminConfigService {
@Override
@Override
public
List
<
VersionDTO
>
findVersionsByApp
(
lo
ng
appId
)
{
public
List
<
VersionDTO
>
findVersionsByApp
(
Stri
ng
appId
)
{
if
(
appId
<=
0
)
{
if
(
Strings
.
isNullOrEmpty
(
appId
)
)
{
return
Collections
.
EMPTY_LIST
;
return
Collections
.
EMPTY_LIST
;
}
}
...
@@ -77,8 +79,8 @@ public class AdminConfigServiceImpl implements AdminConfigService {
...
@@ -77,8 +79,8 @@ public class AdminConfigServiceImpl implements AdminConfigService {
}
}
@Override
@Override
public
List
<
ClusterDTO
>
findClustersByApp
(
lo
ng
appId
)
{
public
List
<
ClusterDTO
>
findClustersByApp
(
Stri
ng
appId
)
{
if
(
appId
<=
0
)
{
if
(
Strings
.
isNullOrEmpty
(
appId
)
)
{
return
Collections
.
EMPTY_LIST
;
return
Collections
.
EMPTY_LIST
;
}
}
List
<
Cluster
>
clusters
=
clusterRepository
.
findByAppId
(
appId
);
List
<
Cluster
>
clusters
=
clusterRepository
.
findByAppId
(
appId
);
...
...
apollo-biz/src/main/java/com/ctrip/apollo/biz/service/impl/ConfigServiceImpl.java
View file @
df1c73b7
...
@@ -33,7 +33,7 @@ public class ConfigServiceImpl implements ConfigService {
...
@@ -33,7 +33,7 @@ public class ConfigServiceImpl implements ConfigService {
};
};
@Override
@Override
public
ApolloConfig
loadConfig
(
lo
ng
appId
,
String
clusterName
,
String
versionName
)
{
public
ApolloConfig
loadConfig
(
Stri
ng
appId
,
String
clusterName
,
String
versionName
)
{
Version
version
=
loadVersionByAppIdAndVersionName
(
appId
,
versionName
);
Version
version
=
loadVersionByAppIdAndVersionName
(
appId
,
versionName
);
if
(
version
==
null
)
{
if
(
version
==
null
)
{
return
null
;
return
null
;
...
@@ -43,7 +43,7 @@ public class ConfigServiceImpl implements ConfigService {
...
@@ -43,7 +43,7 @@ public class ConfigServiceImpl implements ConfigService {
}
}
@Override
@Override
public
Version
loadVersionByAppIdAndVersionName
(
lo
ng
appId
,
String
versionName
)
{
public
Version
loadVersionByAppIdAndVersionName
(
Stri
ng
appId
,
String
versionName
)
{
return
versionRepository
.
findByAppIdAndName
(
appId
,
versionName
);
return
versionRepository
.
findByAppIdAndName
(
appId
,
versionName
);
}
}
...
...
apollo-biz/src/test/java/com/ctrip/apollo/biz/service/impl/ConfigServiceImplTest.java
View file @
df1c73b7
...
@@ -53,7 +53,7 @@ public class ConfigServiceImplTest {
...
@@ -53,7 +53,7 @@ public class ConfigServiceImplTest {
@Test
@Test
public
void
testLoadConfig
()
throws
Exception
{
public
void
testLoadConfig
()
throws
Exception
{
long
someAppId
=
1
;
String
someAppId
=
"1"
;
String
someClusterName
=
"someClusterName"
;
String
someClusterName
=
"someClusterName"
;
String
someVersionName
=
"someVersionName"
;
String
someVersionName
=
"someVersionName"
;
long
someReleaseId
=
1
;
long
someReleaseId
=
1
;
...
@@ -82,7 +82,7 @@ public class ConfigServiceImplTest {
...
@@ -82,7 +82,7 @@ public class ConfigServiceImplTest {
@Test
@Test
public
void
testLoadConfigWithVersionNotFound
()
throws
Exception
{
public
void
testLoadConfigWithVersionNotFound
()
throws
Exception
{
long
someAppId
=
1
;
String
someAppId
=
"1"
;
String
someClusterName
=
"someClusterName"
;
String
someClusterName
=
"someClusterName"
;
String
someVersionName
=
"someVersionName"
;
String
someVersionName
=
"someVersionName"
;
...
@@ -96,7 +96,7 @@ public class ConfigServiceImplTest {
...
@@ -96,7 +96,7 @@ public class ConfigServiceImplTest {
@Test
@Test
public
void
testLoadConfigWithConfigNotFound
()
throws
Exception
{
public
void
testLoadConfigWithConfigNotFound
()
throws
Exception
{
long
someAppId
=
1
;
String
someAppId
=
"1"
;
String
someClusterName
=
"someClusterName"
;
String
someClusterName
=
"someClusterName"
;
String
someVersionName
=
"someVersionName"
;
String
someVersionName
=
"someVersionName"
;
long
someReleaseId
=
1
;
long
someReleaseId
=
1
;
...
@@ -114,7 +114,7 @@ public class ConfigServiceImplTest {
...
@@ -114,7 +114,7 @@ public class ConfigServiceImplTest {
.
findByReleaseIdAndClusterName
(
someReleaseId
,
someClusterName
);
.
findByReleaseIdAndClusterName
(
someReleaseId
,
someClusterName
);
}
}
private
Version
assembleVersion
(
lo
ng
appId
,
String
versionName
,
long
releaseId
)
{
private
Version
assembleVersion
(
Stri
ng
appId
,
String
versionName
,
long
releaseId
)
{
Version
version
=
new
Version
();
Version
version
=
new
Version
();
version
.
setAppId
(
appId
);
version
.
setAppId
(
appId
);
version
.
setName
(
versionName
);
version
.
setName
(
versionName
);
...
...
apollo-client/src/main/java/com/ctrip/apollo/client/env/ClientEnvironment.java
View file @
df1c73b7
...
@@ -17,7 +17,7 @@ public class ClientEnvironment {
...
@@ -17,7 +17,7 @@ public class ClientEnvironment {
private
static
final
Logger
logger
=
LoggerFactory
.
getLogger
(
ClientEnvironment
.
class
);
private
static
final
Logger
logger
=
LoggerFactory
.
getLogger
(
ClientEnvironment
.
class
);
private
static
final
String
DEFAULT_FILE
=
"
/
apollo.properties"
;
private
static
final
String
DEFAULT_FILE
=
"apollo.properties"
;
private
AtomicReference
<
Env
>
env
=
new
AtomicReference
<
Env
>();
private
AtomicReference
<
Env
>
env
=
new
AtomicReference
<
Env
>();
...
...
apollo-client/src/main/java/com/ctrip/apollo/client/loader/ConfigLoaderManager.java
View file @
df1c73b7
...
@@ -188,7 +188,7 @@ public class ConfigLoaderManager {
...
@@ -188,7 +188,7 @@ public class ConfigLoaderManager {
}
}
private
String
assemblePropertySourceName
(
ApolloConfig
apolloConfig
)
{
private
String
assemblePropertySourceName
(
ApolloConfig
apolloConfig
)
{
return
String
.
format
(
"%
d
-%s-%s-%d"
,
apolloConfig
.
getAppId
(),
apolloConfig
.
getCluster
(),
return
String
.
format
(
"%
s
-%s-%s-%d"
,
apolloConfig
.
getAppId
(),
apolloConfig
.
getCluster
(),
apolloConfig
.
getVersion
(),
apolloConfig
.
getReleaseId
());
apolloConfig
.
getVersion
(),
apolloConfig
.
getReleaseId
());
}
}
}
}
apollo-client/src/main/java/com/ctrip/apollo/client/loader/impl/RemoteConfigLoader.java
View file @
df1c73b7
...
@@ -40,7 +40,7 @@ public class RemoteConfigLoader extends AbstractConfigLoader {
...
@@ -40,7 +40,7 @@ public class RemoteConfigLoader extends AbstractConfigLoader {
ApolloConfig
getRemoteConfig
(
RestTemplate
restTemplate
,
String
uri
,
String
cluster
,
ApolloConfig
getRemoteConfig
(
RestTemplate
restTemplate
,
String
uri
,
String
cluster
,
ApolloRegistry
apolloRegistry
,
ApolloConfig
previousConfig
)
{
ApolloRegistry
apolloRegistry
,
ApolloConfig
previousConfig
)
{
lo
ng
appId
=
apolloRegistry
.
getAppId
();
Stri
ng
appId
=
apolloRegistry
.
getAppId
();
String
version
=
apolloRegistry
.
getVersion
();
String
version
=
apolloRegistry
.
getVersion
();
logger
.
info
(
"Loading config from {}, appId={}, cluster={}, version={}"
,
uri
,
appId
,
cluster
,
logger
.
info
(
"Loading config from {}, appId={}, cluster={}, version={}"
,
uri
,
appId
,
cluster
,
...
...
apollo-client/src/main/java/com/ctrip/apollo/client/model/ApolloRegistry.java
View file @
df1c73b7
...
@@ -6,14 +6,14 @@ import com.google.common.base.MoreObjects;
...
@@ -6,14 +6,14 @@ import com.google.common.base.MoreObjects;
* @author Jason Song(song_s@ctrip.com)
* @author Jason Song(song_s@ctrip.com)
*/
*/
public
class
ApolloRegistry
{
public
class
ApolloRegistry
{
private
lo
ng
appId
;
private
Stri
ng
appId
;
private
String
version
;
private
String
version
;
public
lo
ng
getAppId
()
{
public
Stri
ng
getAppId
()
{
return
appId
;
return
appId
;
}
}
public
void
setAppId
(
lo
ng
appId
)
{
public
void
setAppId
(
Stri
ng
appId
)
{
this
.
appId
=
appId
;
this
.
appId
=
appId
;
}
}
...
...
apollo-client/src/main/java/com/ctrip/apollo/client/util/ConfigUtil.java
View file @
df1c73b7
...
@@ -67,7 +67,7 @@ public class ConfigUtil {
...
@@ -67,7 +67,7 @@ public class ConfigUtil {
return
null
;
return
null
;
}
}
ApolloRegistry
registry
=
new
ApolloRegistry
();
ApolloRegistry
registry
=
new
ApolloRegistry
();
registry
.
setAppId
(
Long
.
parseLong
(
properties
.
getProperty
(
Constants
.
APP_ID
)
));
registry
.
setAppId
(
properties
.
getProperty
(
Constants
.
APP_ID
));
registry
.
setVersion
(
registry
.
setVersion
(
properties
.
getProperty
(
Constants
.
VERSION
,
Constants
.
DEFAULT_VERSION_NAME
));
properties
.
getProperty
(
Constants
.
VERSION
,
Constants
.
DEFAULT_VERSION_NAME
));
return
registry
;
return
registry
;
...
...
apollo-client/src/test/java/com/ctrip/apollo/client/loader/ConfigLoaderManagerTest.java
View file @
df1c73b7
...
@@ -51,8 +51,8 @@ public class ConfigLoaderManagerTest {
...
@@ -51,8 +51,8 @@ public class ConfigLoaderManagerTest {
@Test
@Test
public
void
testLoadPropertySource
()
throws
Exception
{
public
void
testLoadPropertySource
()
throws
Exception
{
long
someAppId
=
100
;
String
someAppId
=
"100"
;
long
anotherAppId
=
101
;
String
anotherAppId
=
"101"
;
ApolloRegistry
someApolloRegistry
=
assembleSomeApolloRegistry
(
someAppId
,
"someVersion"
);
ApolloRegistry
someApolloRegistry
=
assembleSomeApolloRegistry
(
someAppId
,
"someVersion"
);
ApolloRegistry
ApolloRegistry
anotherApolloRegistry
=
anotherApolloRegistry
=
...
@@ -92,7 +92,7 @@ public class ConfigLoaderManagerTest {
...
@@ -92,7 +92,7 @@ public class ConfigLoaderManagerTest {
@Test
(
expected
=
RuntimeException
.
class
)
@Test
(
expected
=
RuntimeException
.
class
)
public
void
testLoadPropertySourceWithError
()
throws
Exception
{
public
void
testLoadPropertySourceWithError
()
throws
Exception
{
Exception
someException
=
mock
(
Exception
.
class
);
Exception
someException
=
mock
(
Exception
.
class
);
long
someAppId
=
100
;
String
someAppId
=
"100"
;
ApolloRegistry
someApolloRegistry
=
assembleSomeApolloRegistry
(
someAppId
,
"someVersion"
);
ApolloRegistry
someApolloRegistry
=
assembleSomeApolloRegistry
(
someAppId
,
"someVersion"
);
when
(
configUtil
.
loadApolloRegistries
()).
thenReturn
(
Lists
.
newArrayList
(
someApolloRegistry
));
when
(
configUtil
.
loadApolloRegistries
()).
thenReturn
(
Lists
.
newArrayList
(
someApolloRegistry
));
...
@@ -114,7 +114,7 @@ public class ConfigLoaderManagerTest {
...
@@ -114,7 +114,7 @@ public class ConfigLoaderManagerTest {
public
void
testLoadSingleApolloConfig
()
throws
Exception
{
public
void
testLoadSingleApolloConfig
()
throws
Exception
{
ApolloConfig
someApolloConfig
=
mock
(
ApolloConfig
.
class
);
ApolloConfig
someApolloConfig
=
mock
(
ApolloConfig
.
class
);
Map
<
String
,
Object
>
someMap
=
Maps
.
newHashMap
();
Map
<
String
,
Object
>
someMap
=
Maps
.
newHashMap
();
long
someAppId
=
100
;
String
someAppId
=
"100"
;
ApolloRegistry
someApolloRegistry
=
assembleSomeApolloRegistry
(
someAppId
,
"someVersion"
);
ApolloRegistry
someApolloRegistry
=
assembleSomeApolloRegistry
(
someAppId
,
"someVersion"
);
ApolloConfig
previousConfig
=
null
;
ApolloConfig
previousConfig
=
null
;
...
@@ -130,7 +130,7 @@ public class ConfigLoaderManagerTest {
...
@@ -130,7 +130,7 @@ public class ConfigLoaderManagerTest {
@Test
@Test
public
void
testReloadPropertySource
()
throws
Exception
{
public
void
testReloadPropertySource
()
throws
Exception
{
long
someAppId
=
100
;
String
someAppId
=
"100"
;
ApolloRegistry
someApolloRegistry
=
assembleSomeApolloRegistry
(
someAppId
,
"someVersion"
);
ApolloRegistry
someApolloRegistry
=
assembleSomeApolloRegistry
(
someAppId
,
"someVersion"
);
ApolloConfig
someApolloConfig
=
mock
(
ApolloConfig
.
class
);
ApolloConfig
someApolloConfig
=
mock
(
ApolloConfig
.
class
);
Map
<
String
,
Object
>
someMap
=
mock
(
Map
.
class
);
Map
<
String
,
Object
>
someMap
=
mock
(
Map
.
class
);
...
@@ -162,7 +162,7 @@ public class ConfigLoaderManagerTest {
...
@@ -162,7 +162,7 @@ public class ConfigLoaderManagerTest {
@Test
@Test
public
void
testCalcPropertyChanges
()
throws
Exception
{
public
void
testCalcPropertyChanges
()
throws
Exception
{
long
someAppId
=
1
;
String
someAppId
=
"1"
;
Map
<
String
,
Object
>
someConfig
=
Maps
.
newHashMap
();
Map
<
String
,
Object
>
someConfig
=
Maps
.
newHashMap
();
someConfig
.
put
(
"key1"
,
"val1"
);
someConfig
.
put
(
"key1"
,
"val1"
);
someConfig
.
put
(
"key2"
,
"val2"
);
someConfig
.
put
(
"key2"
,
"val2"
);
...
@@ -195,7 +195,7 @@ public class ConfigLoaderManagerTest {
...
@@ -195,7 +195,7 @@ public class ConfigLoaderManagerTest {
)));
)));
}
}
ApolloConfig
assembleApolloConfig
(
lo
ng
appId
,
Map
<
String
,
Object
>
configurations
)
{
ApolloConfig
assembleApolloConfig
(
Stri
ng
appId
,
Map
<
String
,
Object
>
configurations
)
{
String
someCluster
=
"someCluster"
;
String
someCluster
=
"someCluster"
;
String
someVersion
=
"someVersion"
;
String
someVersion
=
"someVersion"
;
long
someReleaseId
=
1
;
long
someReleaseId
=
1
;
...
@@ -207,7 +207,7 @@ public class ConfigLoaderManagerTest {
...
@@ -207,7 +207,7 @@ public class ConfigLoaderManagerTest {
return
config
;
return
config
;
}
}
private
ApolloRegistry
assembleSomeApolloRegistry
(
lo
ng
someAppId
,
String
someVersion
)
{
private
ApolloRegistry
assembleSomeApolloRegistry
(
Stri
ng
someAppId
,
String
someVersion
)
{
ApolloRegistry
someApolloRegistry
=
new
ApolloRegistry
();
ApolloRegistry
someApolloRegistry
=
new
ApolloRegistry
();
someApolloRegistry
.
setAppId
(
someAppId
);
someApolloRegistry
.
setAppId
(
someAppId
);
someApolloRegistry
.
setVersion
(
someVersion
);
someApolloRegistry
.
setVersion
(
someVersion
);
...
...
apollo-client/src/test/java/com/ctrip/apollo/client/loader/impl/RemoteConfigLoaderTest.java
View file @
df1c73b7
...
@@ -56,7 +56,7 @@ public class RemoteConfigLoaderTest {
...
@@ -56,7 +56,7 @@ public class RemoteConfigLoaderTest {
String
someServerUrl
=
"http://someUrl"
;
String
someServerUrl
=
"http://someUrl"
;
String
someCluster
=
"some cluster"
;
String
someCluster
=
"some cluster"
;
ApolloConfig
apolloConfig
=
mock
(
ApolloConfig
.
class
);
ApolloConfig
apolloConfig
=
mock
(
ApolloConfig
.
class
);
long
someAppId
=
1
;
String
someAppId
=
"1"
;
ApolloRegistry
apolloRegistry
=
assembleSomeApolloRegistry
(
someAppId
,
"someVersion"
);
ApolloRegistry
apolloRegistry
=
assembleSomeApolloRegistry
(
someAppId
,
"someVersion"
);
ApolloConfig
previousConfig
=
null
;
ApolloConfig
previousConfig
=
null
;
...
@@ -76,7 +76,7 @@ public class RemoteConfigLoaderTest {
...
@@ -76,7 +76,7 @@ public class RemoteConfigLoaderTest {
@Test
@Test
public
void
testGetRemoteConfig
()
throws
Exception
{
public
void
testGetRemoteConfig
()
throws
Exception
{
long
someAppId
=
1
;
String
someAppId
=
"1"
;
String
someServerUrl
=
"http://someServer"
;
String
someServerUrl
=
"http://someServer"
;
String
someClusterName
=
"someCluster"
;
String
someClusterName
=
"someCluster"
;
String
someVersionName
=
"someVersion"
;
String
someVersionName
=
"someVersion"
;
...
@@ -100,7 +100,7 @@ public class RemoteConfigLoaderTest {
...
@@ -100,7 +100,7 @@ public class RemoteConfigLoaderTest {
@Test
(
expected
=
RuntimeException
.
class
)
@Test
(
expected
=
RuntimeException
.
class
)
public
void
testGetRemoteConfigWithServerError
()
throws
Exception
{
public
void
testGetRemoteConfigWithServerError
()
throws
Exception
{
long
someAppId
=
1
;
String
someAppId
=
"1"
;
String
someServerUrl
=
"http://someServer"
;
String
someServerUrl
=
"http://someServer"
;
String
someClusterName
=
"someCluster"
;
String
someClusterName
=
"someCluster"
;
String
someVersionName
=
"someVersion"
;
String
someVersionName
=
"someVersion"
;
...
@@ -118,7 +118,7 @@ public class RemoteConfigLoaderTest {
...
@@ -118,7 +118,7 @@ public class RemoteConfigLoaderTest {
@Test
@Test
public
void
testGetRemoteConfigWith304Response
()
throws
Exception
{
public
void
testGetRemoteConfigWith304Response
()
throws
Exception
{
long
someAppId
=
1
;
String
someAppId
=
"1"
;
String
someServerUrl
=
"http://someServer"
;
String
someServerUrl
=
"http://someServer"
;
String
someClusterName
=
"someCluster"
;
String
someClusterName
=
"someCluster"
;
String
someVersionName
=
"someVersion"
;
String
someVersionName
=
"someVersion"
;
...
@@ -138,7 +138,7 @@ public class RemoteConfigLoaderTest {
...
@@ -138,7 +138,7 @@ public class RemoteConfigLoaderTest {
assertNull
(
result
);
assertNull
(
result
);
}
}
private
ApolloRegistry
assembleSomeApolloRegistry
(
lo
ng
someAppId
,
String
someVersion
)
{
private
ApolloRegistry
assembleSomeApolloRegistry
(
Stri
ng
someAppId
,
String
someVersion
)
{
ApolloRegistry
someApolloRegistry
=
new
ApolloRegistry
();
ApolloRegistry
someApolloRegistry
=
new
ApolloRegistry
();
someApolloRegistry
.
setAppId
(
someAppId
);
someApolloRegistry
.
setAppId
(
someAppId
);
someApolloRegistry
.
setVersion
(
someVersion
);
someApolloRegistry
.
setVersion
(
someVersion
);
...
...
apollo-client/src/test/java/com/ctrip/apollo/client/util/ConfigUtilTest.java
View file @
df1c73b7
...
@@ -60,7 +60,7 @@ public class ConfigUtilTest {
...
@@ -60,7 +60,7 @@ public class ConfigUtilTest {
ApolloRegistry
apolloRegistry
=
apolloRegistries
.
get
(
0
);
ApolloRegistry
apolloRegistry
=
apolloRegistries
.
get
(
0
);
assertEquals
(
1
,
apolloRegistries
.
size
());
assertEquals
(
1
,
apolloRegistries
.
size
());
assertEquals
(
Long
.
parseLong
(
someAppId
)
,
apolloRegistry
.
getAppId
());
assertEquals
(
someAppId
,
apolloRegistry
.
getAppId
());
assertEquals
(
someVersionId
,
apolloRegistry
.
getVersion
());
assertEquals
(
someVersionId
,
apolloRegistry
.
getVersion
());
}
}
...
...
apollo-configservice/src/main/java/com/ctrip/apollo/configservice/controller/ConfigController.java
View file @
df1c73b7
...
@@ -25,7 +25,7 @@ public class ConfigController {
...
@@ -25,7 +25,7 @@ public class ConfigController {
private
ConfigService
configService
;
private
ConfigService
configService
;
@RequestMapping
(
value
=
"/{appId}/{clusterName}/{versionName:.*}"
,
method
=
RequestMethod
.
GET
)
@RequestMapping
(
value
=
"/{appId}/{clusterName}/{versionName:.*}"
,
method
=
RequestMethod
.
GET
)
public
ApolloConfig
queryConfig
(
@PathVariable
lo
ng
appId
,
public
ApolloConfig
queryConfig
(
@PathVariable
Stri
ng
appId
,
@PathVariable
String
clusterName
,
@PathVariable
String
clusterName
,
@PathVariable
String
versionName
,
@PathVariable
String
versionName
,
@RequestParam
(
value
=
"releaseId"
,
defaultValue
=
"-1"
)
long
clientSideReleaseId
,
@RequestParam
(
value
=
"releaseId"
,
defaultValue
=
"-1"
)
long
clientSideReleaseId
,
...
@@ -33,7 +33,7 @@ public class ConfigController {
...
@@ -33,7 +33,7 @@ public class ConfigController {
Version
version
=
configService
.
loadVersionByAppIdAndVersionName
(
appId
,
versionName
);
Version
version
=
configService
.
loadVersionByAppIdAndVersionName
(
appId
,
versionName
);
if
(
version
==
null
)
{
if
(
version
==
null
)
{
response
.
sendError
(
HttpServletResponse
.
SC_NOT_FOUND
,
response
.
sendError
(
HttpServletResponse
.
SC_NOT_FOUND
,
String
.
format
(
"Could not load version with appId: %
d
, versionName: %s"
,
appId
,
String
.
format
(
"Could not load version with appId: %
s
, versionName: %s"
,
appId
,
versionName
));
versionName
));
return
null
;
return
null
;
}
}
...
...
apollo-configservice/src/test/java/com/ctrip/apollo/configservice/controller/ConfigControllerTest.java
View file @
df1c73b7
...
@@ -42,7 +42,7 @@ public class ConfigControllerTest {
...
@@ -42,7 +42,7 @@ public class ConfigControllerTest {
@Test
@Test
public
void
testQueryConfig
()
throws
Exception
{
public
void
testQueryConfig
()
throws
Exception
{
ApolloConfig
someApolloConfig
=
mock
(
ApolloConfig
.
class
);
ApolloConfig
someApolloConfig
=
mock
(
ApolloConfig
.
class
);
long
someAppId
=
1
;
String
someAppId
=
"1"
;
String
someClusterName
=
"someClusterName"
;
String
someClusterName
=
"someClusterName"
;
String
someVersionName
=
"someVersion"
;
String
someVersionName
=
"someVersion"
;
long
someClientSideReleaseId
=
1
;
long
someClientSideReleaseId
=
1
;
...
@@ -69,7 +69,7 @@ public class ConfigControllerTest {
...
@@ -69,7 +69,7 @@ public class ConfigControllerTest {
@Test
@Test
public
void
testQueryConfigWithVersionNotFound
()
throws
Exception
{
public
void
testQueryConfigWithVersionNotFound
()
throws
Exception
{
long
someAppId
=
1
;
String
someAppId
=
"1"
;
String
someClusterName
=
"someClusterName"
;
String
someClusterName
=
"someClusterName"
;
String
someVersionName
=
"someVersion"
;
String
someVersionName
=
"someVersion"
;
long
someClientSideReleaseId
=
1
;
long
someClientSideReleaseId
=
1
;
...
@@ -90,7 +90,7 @@ public class ConfigControllerTest {
...
@@ -90,7 +90,7 @@ public class ConfigControllerTest {
@Test
@Test
public
void
testQueryConfigWithApolloConfigNotFound
()
throws
Exception
{
public
void
testQueryConfigWithApolloConfigNotFound
()
throws
Exception
{
long
someAppId
=
1
;
String
someAppId
=
"1"
;
String
someClusterName
=
"someClusterName"
;
String
someClusterName
=
"someClusterName"
;
String
someVersionName
=
"someVersion"
;
String
someVersionName
=
"someVersion"
;
long
someClientSideReleaseId
=
1
;
long
someClientSideReleaseId
=
1
;
...
@@ -116,7 +116,7 @@ public class ConfigControllerTest {
...
@@ -116,7 +116,7 @@ public class ConfigControllerTest {
@Test
@Test
public
void
testQueryConfigWithApolloConfigNotModified
()
throws
Exception
{
public
void
testQueryConfigWithApolloConfigNotModified
()
throws
Exception
{
long
someAppId
=
1
;
String
someAppId
=
"1"
;
String
someClusterName
=
"someClusterName"
;
String
someClusterName
=
"someClusterName"
;
String
someVersionName
=
"someVersion"
;
String
someVersionName
=
"someVersion"
;
long
someClientSideReleaseId
=
1
;
long
someClientSideReleaseId
=
1
;
...
...
apollo-core/src/main/java/com/ctrip/apollo/core/dto/ApolloConfig.java
View file @
df1c73b7
...
@@ -12,7 +12,7 @@ import java.util.Map;
...
@@ -12,7 +12,7 @@ import java.util.Map;
*/
*/
public
class
ApolloConfig
implements
Comparable
<
ApolloConfig
>
{
public
class
ApolloConfig
implements
Comparable
<
ApolloConfig
>
{
private
lo
ng
appId
;
private
Stri
ng
appId
;
private
String
cluster
;
private
String
cluster
;
...
@@ -25,7 +25,7 @@ public class ApolloConfig implements Comparable<ApolloConfig> {
...
@@ -25,7 +25,7 @@ public class ApolloConfig implements Comparable<ApolloConfig> {
private
int
order
;
private
int
order
;
@JsonCreator
@JsonCreator
public
ApolloConfig
(
@JsonProperty
(
"appId"
)
lo
ng
appId
,
public
ApolloConfig
(
@JsonProperty
(
"appId"
)
Stri
ng
appId
,
@JsonProperty
(
"cluster"
)
String
cluster
,
@JsonProperty
(
"cluster"
)
String
cluster
,
@JsonProperty
(
"version"
)
String
version
,
@JsonProperty
(
"version"
)
String
version
,
@JsonProperty
(
"releaseId"
)
long
releaseId
)
{
@JsonProperty
(
"releaseId"
)
long
releaseId
)
{
...
@@ -44,7 +44,7 @@ public class ApolloConfig implements Comparable<ApolloConfig> {
...
@@ -44,7 +44,7 @@ public class ApolloConfig implements Comparable<ApolloConfig> {
this
.
configurations
=
configurations
;
this
.
configurations
=
configurations
;
}
}
public
lo
ng
getAppId
()
{
public
Stri
ng
getAppId
()
{
return
appId
;
return
appId
;
}
}
...
...
apollo-core/src/main/java/com/ctrip/apollo/core/dto/ClusterDTO.java
View file @
df1c73b7
...
@@ -6,7 +6,7 @@ public class ClusterDTO {
...
@@ -6,7 +6,7 @@ public class ClusterDTO {
private
String
name
;
private
String
name
;
private
lo
ng
appId
;
private
Stri
ng
appId
;
public
long
getId
()
{
public
long
getId
()
{
return
id
;
return
id
;
...
@@ -24,11 +24,11 @@ public class ClusterDTO {
...
@@ -24,11 +24,11 @@ public class ClusterDTO {
this
.
name
=
name
;
this
.
name
=
name
;
}
}
public
lo
ng
getAppId
()
{
public
Stri
ng
getAppId
()
{
return
appId
;
return
appId
;
}
}
public
void
setAppId
(
lo
ng
appId
)
{
public
void
setAppId
(
Stri
ng
appId
)
{
this
.
appId
=
appId
;
this
.
appId
=
appId
;
}
}
}
}
apollo-core/src/main/java/com/ctrip/apollo/core/dto/ConfigItemDTO.java
View file @
df1c73b7
...
@@ -10,7 +10,7 @@ public class ConfigItemDTO {
...
@@ -10,7 +10,7 @@ public class ConfigItemDTO {
private
String
clusterName
;
private
String
clusterName
;
private
lo
ng
appId
;
private
Stri
ng
appId
;
private
String
key
;
private
String
key
;
...
@@ -59,11 +59,11 @@ public class ConfigItemDTO {
...
@@ -59,11 +59,11 @@ public class ConfigItemDTO {
this
.
clusterName
=
clusterName
;
this
.
clusterName
=
clusterName
;
}
}
public
lo
ng
getAppId
()
{
public
Stri
ng
getAppId
()
{
return
appId
;
return
appId
;
}
}
public
void
setAppId
(
lo
ng
appId
)
{
public
void
setAppId
(
Stri
ng
appId
)
{
this
.
appId
=
appId
;
this
.
appId
=
appId
;
}
}
...
...
apollo-core/src/main/java/com/ctrip/apollo/core/dto/VersionDTO.java
View file @
df1c73b7
...
@@ -6,7 +6,7 @@ public class VersionDTO {
...
@@ -6,7 +6,7 @@ public class VersionDTO {
private
String
name
;
private
String
name
;
private
lo
ng
appId
;
private
Stri
ng
appId
;
private
long
releaseId
;
private
long
releaseId
;
...
@@ -32,11 +32,11 @@ public class VersionDTO {
...
@@ -32,11 +32,11 @@ public class VersionDTO {
this
.
name
=
name
;
this
.
name
=
name
;
}
}
public
lo
ng
getAppId
()
{
public
Stri
ng
getAppId
()
{
return
appId
;
return
appId
;
}
}
public
void
setAppId
(
lo
ng
appId
)
{
public
void
setAppId
(
Stri
ng
appId
)
{
this
.
appId
=
appId
;
this
.
appId
=
appId
;
}
}
...
...
apollo-portal/src/main/java/com/ctrip/apollo/portal/api/AdminServiceAPI.java
View file @
df1c73b7
package
com
.
ctrip
.
apollo
.
portal
.
api
;
package
com
.
ctrip
.
apollo
.
portal
.
api
;
import
com.google.common.base.Strings
;
import
com.ctrip.apollo.Apollo
;
import
com.ctrip.apollo.Apollo
;
import
com.ctrip.apollo.core.dto.ClusterDTO
;
import
com.ctrip.apollo.core.dto.ClusterDTO
;
import
com.ctrip.apollo.core.dto.ConfigItemDTO
;
import
com.ctrip.apollo.core.dto.ConfigItemDTO
;
...
@@ -45,8 +47,8 @@ public class AdminServiceAPI {
...
@@ -45,8 +47,8 @@ public class AdminServiceAPI {
public
static
String
CLUSTER_APP_API
=
"/cluster/app/"
;
public
static
String
CLUSTER_APP_API
=
"/cluster/app/"
;
public
ClusterDTO
[]
getClustersByApp
(
Apollo
.
Env
env
,
lo
ng
appId
)
{
public
ClusterDTO
[]
getClustersByApp
(
Apollo
.
Env
env
,
Stri
ng
appId
)
{
if
(
appId
<=
0
)
{
if
(
Strings
.
isNullOrEmpty
(
appId
)
)
{
return
null
;
return
null
;
}
}
...
@@ -68,8 +70,8 @@ public class AdminServiceAPI {
...
@@ -68,8 +70,8 @@ public class AdminServiceAPI {
return
restTemplate
.
getForObject
(
getAdminServiceHost
(
env
)
+
VERSION_API
+
versionId
,
VersionDTO
.
class
);
return
restTemplate
.
getForObject
(
getAdminServiceHost
(
env
)
+
VERSION_API
+
versionId
,
VersionDTO
.
class
);
}
}
public
VersionDTO
[]
getVersionsByApp
(
Apollo
.
Env
env
,
lo
ng
appId
){
public
VersionDTO
[]
getVersionsByApp
(
Apollo
.
Env
env
,
Stri
ng
appId
){
if
(
appId
<=
0
){
if
(
Strings
.
isNullOrEmpty
(
appId
)
){
return
null
;
return
null
;
}
}
return
restTemplate
.
getForObject
(
getAdminServiceHost
(
env
)
+
VERSION_APP_API
+
appId
,
return
restTemplate
.
getForObject
(
getAdminServiceHost
(
env
)
+
VERSION_APP_API
+
appId
,
...
...
apollo-portal/src/main/java/com/ctrip/apollo/portal/controller/AppController.java
View file @
df1c73b7
...
@@ -28,7 +28,7 @@ public class AppController {
...
@@ -28,7 +28,7 @@ public class AppController {
}
}
@RequestMapping
(
"/{appid}"
)
@RequestMapping
(
"/{appid}"
)
public
App
detail
(
@PathVariable
lo
ng
appid
)
{
public
App
detail
(
@PathVariable
Stri
ng
appid
)
{
App
app
=
appService
.
detail
(
appid
);
App
app
=
appService
.
detail
(
appid
);
if
(
app
==
null
)
{
if
(
app
==
null
)
{
throw
new
NotFoundException
();
throw
new
NotFoundException
();
...
...
apollo-portal/src/main/java/com/ctrip/apollo/portal/controller/ConfigController.java
View file @
df1c73b7
package
com
.
ctrip
.
apollo
.
portal
.
controller
;
package
com
.
ctrip
.
apollo
.
portal
.
controller
;
import
com.google.common.base.Strings
;
import
com.ctrip.apollo.Apollo
;
import
com.ctrip.apollo.Apollo
;
import
com.ctrip.apollo.portal.constants.PortalConstants
;
import
com.ctrip.apollo.portal.constants.PortalConstants
;
import
com.ctrip.apollo.portal.entity.AppConfigVO
;
import
com.ctrip.apollo.portal.entity.AppConfigVO
;
...
@@ -19,10 +21,10 @@ public class ConfigController {
...
@@ -19,10 +21,10 @@ public class ConfigController {
private
ConfigService
configService
;
private
ConfigService
configService
;
@RequestMapping
(
"/{appId}/{env}/{versionId}"
)
@RequestMapping
(
"/{appId}/{env}/{versionId}"
)
public
AppConfigVO
detail
(
@PathVariable
lo
ng
appId
,
@PathVariable
String
env
,
public
AppConfigVO
detail
(
@PathVariable
Stri
ng
appId
,
@PathVariable
String
env
,
@PathVariable
long
versionId
)
{
@PathVariable
long
versionId
)
{
if
(
appId
<=
0
)
{
if
(
Strings
.
isNullOrEmpty
(
appId
)
)
{
throw
new
NotFoundException
();
throw
new
NotFoundException
();
}
}
...
...
apollo-portal/src/main/java/com/ctrip/apollo/portal/controller/VersionController.java
View file @
df1c73b7
...
@@ -19,7 +19,7 @@ public class VersionController {
...
@@ -19,7 +19,7 @@ public class VersionController {
private
VersionService
versionService
;
private
VersionService
versionService
;
@RequestMapping
(
"/{appId}/{env}"
)
@RequestMapping
(
"/{appId}/{env}"
)
public
List
<
VersionDTO
>
versions
(
@PathVariable
lo
ng
appId
,
@PathVariable
String
env
)
{
public
List
<
VersionDTO
>
versions
(
@PathVariable
Stri
ng
appId
,
@PathVariable
String
env
)
{
return
versionService
.
findVersionsByApp
(
Apollo
.
Env
.
DEV
,
appId
);
return
versionService
.
findVersionsByApp
(
Apollo
.
Env
.
DEV
,
appId
);
}
}
}
}
apollo-portal/src/main/java/com/ctrip/apollo/portal/entity/App.java
View file @
df1c73b7
...
@@ -16,7 +16,7 @@ public class App implements Serializable {
...
@@ -16,7 +16,7 @@ public class App implements Serializable {
private
static
final
long
serialVersionUID
=
7348554309210401557L
;
private
static
final
long
serialVersionUID
=
7348554309210401557L
;
@Id
@Id
private
lo
ng
appId
;
private
Stri
ng
appId
;
@Column
(
nullable
=
false
)
@Column
(
nullable
=
false
)
private
String
name
;
private
String
name
;
...
@@ -37,11 +37,11 @@ public class App implements Serializable {
...
@@ -37,11 +37,11 @@ public class App implements Serializable {
private
Date
lastUpdatedTimestamp
;
private
Date
lastUpdatedTimestamp
;
public
lo
ng
getAppId
()
{
public
Stri
ng
getAppId
()
{
return
appId
;
return
appId
;
}
}
public
void
setAppId
(
lo
ng
appId
)
{
public
void
setAppId
(
Stri
ng
appId
)
{
this
.
appId
=
appId
;
this
.
appId
=
appId
;
}
}
...
...
apollo-portal/src/main/java/com/ctrip/apollo/portal/entity/AppConfigVO.java
View file @
df1c73b7
...
@@ -9,7 +9,7 @@ import java.util.List;
...
@@ -9,7 +9,7 @@ import java.util.List;
public
class
AppConfigVO
{
public
class
AppConfigVO
{
private
lo
ng
appId
;
private
Stri
ng
appId
;
private
Env
env
;
private
Env
env
;
...
@@ -46,7 +46,7 @@ public class AppConfigVO {
...
@@ -46,7 +46,7 @@ public class AppConfigVO {
}
}
public
static
AppConfigVO
newInstance
(
lo
ng
appId
,
long
versionId
)
{
public
static
AppConfigVO
newInstance
(
Stri
ng
appId
,
long
versionId
)
{
AppConfigVO
instance
=
new
AppConfigVO
();
AppConfigVO
instance
=
new
AppConfigVO
();
instance
.
setAppId
(
appId
);
instance
.
setAppId
(
appId
);
instance
.
setVersionId
(
versionId
);
instance
.
setVersionId
(
versionId
);
...
@@ -62,18 +62,18 @@ public class AppConfigVO {
...
@@ -62,18 +62,18 @@ public class AppConfigVO {
public
static
class
OverrideAppConfig
{
public
static
class
OverrideAppConfig
{
private
lo
ng
appId
;
private
Stri
ng
appId
;
private
List
<
ConfigItemDTO
>
configs
;
private
List
<
ConfigItemDTO
>
configs
;
public
OverrideAppConfig
()
{
public
OverrideAppConfig
()
{
}
}
public
lo
ng
getAppId
()
{
public
Stri
ng
getAppId
()
{
return
appId
;
return
appId
;
}
}
public
void
setAppId
(
lo
ng
appId
)
{
public
void
setAppId
(
Stri
ng
appId
)
{
this
.
appId
=
appId
;
this
.
appId
=
appId
;
}
}
...
@@ -120,11 +120,11 @@ public class AppConfigVO {
...
@@ -120,11 +120,11 @@ public class AppConfigVO {
}
}
public
lo
ng
getAppId
()
{
public
Stri
ng
getAppId
()
{
return
appId
;
return
appId
;
}
}
public
void
setAppId
(
lo
ng
appId
)
{
public
void
setAppId
(
Stri
ng
appId
)
{
this
.
appId
=
appId
;
this
.
appId
=
appId
;
}
}
...
...
apollo-portal/src/main/java/com/ctrip/apollo/portal/entity/Privilege.java
View file @
df1c73b7
...
@@ -26,7 +26,7 @@ public class Privilege implements Serializable {
...
@@ -26,7 +26,7 @@ public class Privilege implements Serializable {
private
String
privilType
;
private
String
privilType
;
@Column
@Column
private
lo
ng
appId
;
private
Stri
ng
appId
;
public
long
getId
()
{
public
long
getId
()
{
return
id
;
return
id
;
...
@@ -52,11 +52,11 @@ public class Privilege implements Serializable {
...
@@ -52,11 +52,11 @@ public class Privilege implements Serializable {
this
.
privilType
=
privilType
;
this
.
privilType
=
privilType
;
}
}
public
lo
ng
getAppId
()
{
public
Stri
ng
getAppId
()
{
return
appId
;
return
appId
;
}
}
public
void
setAppId
(
lo
ng
appId
)
{
public
void
setAppId
(
Stri
ng
appId
)
{
this
.
appId
=
appId
;
this
.
appId
=
appId
;
}
}
}
}
apollo-portal/src/main/java/com/ctrip/apollo/portal/repository/AppRepository.java
View file @
df1c73b7
...
@@ -10,5 +10,5 @@ public interface AppRepository extends PagingAndSortingRepository<App, String> {
...
@@ -10,5 +10,5 @@ public interface AppRepository extends PagingAndSortingRepository<App, String> {
Page
<
App
>
findAll
(
Pageable
pageable
);
Page
<
App
>
findAll
(
Pageable
pageable
);
App
findByAppId
(
lo
ng
appId
);
App
findByAppId
(
Stri
ng
appId
);
}
}
apollo-portal/src/main/java/com/ctrip/apollo/portal/repository/PrivilegeRepository.java
View file @
df1c73b7
...
@@ -8,9 +8,9 @@ import java.util.List;
...
@@ -8,9 +8,9 @@ import java.util.List;
public
interface
PrivilegeRepository
extends
PagingAndSortingRepository
<
Privilege
,
Long
>
{
public
interface
PrivilegeRepository
extends
PagingAndSortingRepository
<
Privilege
,
Long
>
{
List
<
Privilege
>
findByAppId
(
lo
ng
appId
);
List
<
Privilege
>
findByAppId
(
Stri
ng
appId
);
List
<
Privilege
>
findByAppIdAndPrivilType
(
lo
ng
appId
,
String
privilType
);
List
<
Privilege
>
findByAppIdAndPrivilType
(
Stri
ng
appId
,
String
privilType
);
Privilege
findByAppIdAndNameAndPrivilType
(
lo
ng
appId
,
String
name
,
String
privilType
);
Privilege
findByAppIdAndNameAndPrivilType
(
Stri
ng
appId
,
String
name
,
String
privilType
);
}
}
apollo-portal/src/main/java/com/ctrip/apollo/portal/service/AppService.java
View file @
df1c73b7
...
@@ -16,7 +16,7 @@ public class AppService {
...
@@ -16,7 +16,7 @@ public class AppService {
@Autowired
@Autowired
private
AppRepository
appRepository
;
private
AppRepository
appRepository
;
public
App
detail
(
lo
ng
appId
)
{
public
App
detail
(
Stri
ng
appId
)
{
return
appRepository
.
findByAppId
(
appId
);
return
appRepository
.
findByAppId
(
appId
);
}
}
...
...
apollo-portal/src/main/java/com/ctrip/apollo/portal/service/ConfigService.java
View file @
df1c73b7
...
@@ -24,6 +24,7 @@ import com.ctrip.apollo.portal.constants.PortalConstants;
...
@@ -24,6 +24,7 @@ import com.ctrip.apollo.portal.constants.PortalConstants;
import
com.ctrip.apollo.portal.entity.AppConfigVO
;
import
com.ctrip.apollo.portal.entity.AppConfigVO
;
import
com.fasterxml.jackson.databind.ObjectMapper
;
import
com.fasterxml.jackson.databind.ObjectMapper
;
import
com.google.common.base.Strings
;
import
com.google.common.collect.Maps
;
import
com.google.common.collect.Maps
;
@Service
@Service
...
@@ -40,8 +41,9 @@ public class ConfigService {
...
@@ -40,8 +41,9 @@ public class ConfigService {
private
ObjectMapper
objectMapper
=
new
ObjectMapper
();
private
ObjectMapper
objectMapper
=
new
ObjectMapper
();
public
AppConfigVO
loadReleaseConfig
(
Env
env
,
long
appId
,
long
versionId
)
{
public
AppConfigVO
loadReleaseConfig
(
Env
env
,
String
appId
,
long
versionId
)
{
if
(
appId
<=
0
||
versionId
<=
0
)
{
if
(
Strings
.
isNullOrEmpty
(
appId
)
||
versionId
<=
0
)
{
return
null
;
return
null
;
}
}
...
@@ -78,18 +80,18 @@ public class ConfigService {
...
@@ -78,18 +80,18 @@ public class ConfigService {
return
version
.
getReleaseId
();
return
version
.
getReleaseId
();
}
}
private
void
collectDefaultClusterConfigs
(
lo
ng
appId
,
ReleaseSnapshotDTO
snapShot
,
private
void
collectDefaultClusterConfigs
(
Stri
ng
appId
,
ReleaseSnapshotDTO
snapShot
,
AppConfigVO
appConfigVO
)
{
AppConfigVO
appConfigVO
)
{
Map
<
Lo
ng
,
List
<
ConfigItemDTO
>>
groupedConfigs
=
groupConfigsByApp
(
snapShot
.
getConfigurations
());
Map
<
Stri
ng
,
List
<
ConfigItemDTO
>>
groupedConfigs
=
groupConfigsByApp
(
snapShot
.
getConfigurations
());
List
<
AppConfigVO
.
OverrideAppConfig
>
overrideAppConfigs
=
appConfigVO
.
getOverrideAppConfigs
();
List
<
AppConfigVO
.
OverrideAppConfig
>
overrideAppConfigs
=
appConfigVO
.
getOverrideAppConfigs
();
for
(
Map
.
Entry
<
Lo
ng
,
List
<
ConfigItemDTO
>>
entry
:
groupedConfigs
.
entrySet
())
{
for
(
Map
.
Entry
<
Stri
ng
,
List
<
ConfigItemDTO
>>
entry
:
groupedConfigs
.
entrySet
())
{
lo
ng
configAppId
=
entry
.
getKey
();
Stri
ng
configAppId
=
entry
.
getKey
();
List
<
ConfigItemDTO
>
kvs
=
entry
.
getValue
();
List
<
ConfigItemDTO
>
kvs
=
entry
.
getValue
();
if
(
configAppId
==
appId
)
{
if
(
configAppId
.
equals
(
appId
)
)
{
appConfigVO
.
setDefaultClusterConfigs
(
kvs
);
appConfigVO
.
setDefaultClusterConfigs
(
kvs
);
}
else
{
}
else
{
...
@@ -105,12 +107,12 @@ public class ConfigService {
...
@@ -105,12 +107,12 @@ public class ConfigService {
/**
/**
* appId -> List<KV>
* appId -> List<KV>
*/
*/
private
Map
<
Lo
ng
,
List
<
ConfigItemDTO
>>
groupConfigsByApp
(
String
configJson
)
{
private
Map
<
Stri
ng
,
List
<
ConfigItemDTO
>>
groupConfigsByApp
(
String
configJson
)
{
if
(
configJson
==
null
||
""
.
equals
(
configJson
))
{
if
(
configJson
==
null
||
""
.
equals
(
configJson
))
{
return
Maps
.
newHashMap
();
return
Maps
.
newHashMap
();
}
}
Map
<
Lo
ng
,
List
<
ConfigItemDTO
>>
appIdMapKVs
=
new
HashMap
<>();
Map
<
Stri
ng
,
List
<
ConfigItemDTO
>>
appIdMapKVs
=
new
HashMap
<>();
String
key
;
String
key
;
Object
value
;
Object
value
;
...
@@ -124,7 +126,7 @@ public class ConfigService {
...
@@ -124,7 +126,7 @@ public class ConfigService {
key
=
entry
.
getKey
();
key
=
entry
.
getKey
();
value
=
entry
.
getValue
();
value
=
entry
.
getValue
();
Lo
ng
appId
=
getAppIdFromKey
(
key
);
Stri
ng
appId
=
getAppIdFromKey
(
key
);
List
<
ConfigItemDTO
>
kvs
=
appIdMapKVs
.
get
(
appId
);
List
<
ConfigItemDTO
>
kvs
=
appIdMapKVs
.
get
(
appId
);
if
(
kvs
==
null
)
{
if
(
kvs
==
null
)
{
kvs
=
new
LinkedList
<>();
kvs
=
new
LinkedList
<>();
...
@@ -137,11 +139,11 @@ public class ConfigService {
...
@@ -137,11 +139,11 @@ public class ConfigService {
}
}
private
Lo
ng
getAppIdFromKey
(
String
key
)
{
private
Stri
ng
getAppIdFromKey
(
String
key
)
{
return
Long
.
valueOf
(
key
.
substring
(
0
,
key
.
indexOf
(
"."
)
));
return
key
.
substring
(
0
,
key
.
indexOf
(
"."
));
}
}
private
void
collectSpecialClusterConfigs
(
lo
ng
appId
,
ReleaseSnapshotDTO
snapShot
,
private
void
collectSpecialClusterConfigs
(
Stri
ng
appId
,
ReleaseSnapshotDTO
snapShot
,
AppConfigVO
appConfigVO
)
{
AppConfigVO
appConfigVO
)
{
List
<
AppConfigVO
.
OverrideClusterConfig
>
overrideClusterConfigs
=
List
<
AppConfigVO
.
OverrideClusterConfig
>
overrideClusterConfigs
=
appConfigVO
.
getOverrideClusterConfigs
();
appConfigVO
.
getOverrideClusterConfigs
();
...
@@ -153,8 +155,8 @@ public class ConfigService {
...
@@ -153,8 +155,8 @@ public class ConfigService {
overrideClusterConfigs
.
add
(
overrideClusterConfig
);
overrideClusterConfigs
.
add
(
overrideClusterConfig
);
}
}
public
AppConfigVO
loadLatestConfig
(
Env
env
,
lo
ng
appId
)
{
public
AppConfigVO
loadLatestConfig
(
Env
env
,
Stri
ng
appId
)
{
if
(
appId
<=
0
)
{
if
(
Strings
.
isNullOrEmpty
(
appId
)
)
{
return
null
;
return
null
;
}
}
...
@@ -173,7 +175,7 @@ public class ConfigService {
...
@@ -173,7 +175,7 @@ public class ConfigService {
return
buildAPPConfigVO
(
appId
,
Arrays
.
asList
(
configItems
));
return
buildAPPConfigVO
(
appId
,
Arrays
.
asList
(
configItems
));
}
}
private
AppConfigVO
buildAPPConfigVO
(
lo
ng
appId
,
List
<
ConfigItemDTO
>
configItems
)
{
private
AppConfigVO
buildAPPConfigVO
(
Stri
ng
appId
,
List
<
ConfigItemDTO
>
configItems
)
{
if
(
configItems
==
null
||
configItems
.
size
()
==
0
)
{
if
(
configItems
==
null
||
configItems
.
size
()
==
0
)
{
return
null
;
return
null
;
}
}
...
@@ -206,7 +208,7 @@ public class ConfigService {
...
@@ -206,7 +208,7 @@ public class ConfigService {
private
void
groupConfigByAppAndEnrichDTO
(
Map
<
String
,
List
<
ConfigItemDTO
>>
groupedClusterConfigs
,
private
void
groupConfigByAppAndEnrichDTO
(
Map
<
String
,
List
<
ConfigItemDTO
>>
groupedClusterConfigs
,
AppConfigVO
appConfigVO
)
{
AppConfigVO
appConfigVO
)
{
lo
ng
appId
=
appConfigVO
.
getAppId
();
Stri
ng
appId
=
appConfigVO
.
getAppId
();
List
<
ConfigItemDTO
>
defaultClusterConfigs
=
appConfigVO
.
getDefaultClusterConfigs
();
List
<
ConfigItemDTO
>
defaultClusterConfigs
=
appConfigVO
.
getDefaultClusterConfigs
();
...
@@ -232,14 +234,14 @@ public class ConfigService {
...
@@ -232,14 +234,14 @@ public class ConfigService {
}
}
}
}
private
void
collectDefaultClusterConfigs
(
lo
ng
appId
,
List
<
ConfigItemDTO
>
clusterConfigs
,
private
void
collectDefaultClusterConfigs
(
Stri
ng
appId
,
List
<
ConfigItemDTO
>
clusterConfigs
,
List
<
ConfigItemDTO
>
defaultClusterConfigs
,
List
<
ConfigItemDTO
>
defaultClusterConfigs
,
List
<
AppConfigVO
.
OverrideAppConfig
>
overrideAppConfigs
)
{
List
<
AppConfigVO
.
OverrideAppConfig
>
overrideAppConfigs
)
{
Map
<
Lo
ng
,
AppConfigVO
.
OverrideAppConfig
>
appIdMapOverrideAppConfig
=
null
;
Map
<
Stri
ng
,
AppConfigVO
.
OverrideAppConfig
>
appIdMapOverrideAppConfig
=
null
;
for
(
ConfigItemDTO
config
:
clusterConfigs
)
{
for
(
ConfigItemDTO
config
:
clusterConfigs
)
{
lo
ng
targetAppId
=
config
.
getAppId
();
Stri
ng
targetAppId
=
config
.
getAppId
();
if
(
appId
==
targetAppId
)
{
// app self's configs
if
(
appId
==
targetAppId
)
{
// app self's configs
defaultClusterConfigs
.
add
(
config
);
defaultClusterConfigs
.
add
(
config
);
}
else
{
// override other app configs
}
else
{
// override other app configs
...
...
apollo-portal/src/main/java/com/ctrip/apollo/portal/service/PrivilegeService.java
View file @
df1c73b7
...
@@ -19,7 +19,7 @@ public class PrivilegeService {
...
@@ -19,7 +19,7 @@ public class PrivilegeService {
@Autowired
@Autowired
private
PrivilegeRepository
privilRepo
;
private
PrivilegeRepository
privilRepo
;
public
Privilege
addPrivilege
(
lo
ng
appId
,
String
name
,
PrivilType
privilType
)
{
public
Privilege
addPrivilege
(
Stri
ng
appId
,
String
name
,
PrivilType
privilType
)
{
Privilege
privil
=
privilRepo
.
findByAppIdAndNameAndPrivilType
(
appId
,
name
,
privilType
.
name
());
Privilege
privil
=
privilRepo
.
findByAppIdAndNameAndPrivilType
(
appId
,
name
,
privilType
.
name
());
if
(
privil
==
null
)
{
if
(
privil
==
null
)
{
privil
=
new
Privilege
();
privil
=
new
Privilege
();
...
@@ -31,16 +31,16 @@ public class PrivilegeService {
...
@@ -31,16 +31,16 @@ public class PrivilegeService {
return
privil
;
return
privil
;
}
}
public
boolean
hasPrivilege
(
lo
ng
appId
,
String
name
,
PrivilType
privilType
)
{
public
boolean
hasPrivilege
(
Stri
ng
appId
,
String
name
,
PrivilType
privilType
)
{
Privilege
privil
=
privilRepo
.
findByAppIdAndNameAndPrivilType
(
appId
,
name
,
privilType
.
name
());
Privilege
privil
=
privilRepo
.
findByAppIdAndNameAndPrivilType
(
appId
,
name
,
privilType
.
name
());
return
(
privil
!=
null
)
?
true
:
false
;
return
(
privil
!=
null
)
?
true
:
false
;
}
}
public
List
<
Privilege
>
listPrivileges
(
lo
ng
appId
)
{
public
List
<
Privilege
>
listPrivileges
(
Stri
ng
appId
)
{
return
privilRepo
.
findByAppId
(
appId
);
return
privilRepo
.
findByAppId
(
appId
);
}
}
public
void
removePrivilege
(
lo
ng
appId
,
String
name
,
PrivilType
privilType
)
{
public
void
removePrivilege
(
Stri
ng
appId
,
String
name
,
PrivilType
privilType
)
{
Privilege
privil
=
privilRepo
.
findByAppIdAndNameAndPrivilType
(
appId
,
name
,
privilType
.
name
());
Privilege
privil
=
privilRepo
.
findByAppIdAndNameAndPrivilType
(
appId
,
name
,
privilType
.
name
());
if
(
privil
==
null
)
{
if
(
privil
==
null
)
{
throw
new
NotFoundException
();
throw
new
NotFoundException
();
...
...
apollo-portal/src/main/java/com/ctrip/apollo/portal/service/VersionService.java
View file @
df1c73b7
...
@@ -17,7 +17,7 @@ public class VersionService {
...
@@ -17,7 +17,7 @@ public class VersionService {
@Autowired
@Autowired
private
AdminServiceAPI
.
VersionAPI
versionAPI
;
private
AdminServiceAPI
.
VersionAPI
versionAPI
;
public
List
<
VersionDTO
>
findVersionsByApp
(
Apollo
.
Env
env
,
lo
ng
appId
)
{
public
List
<
VersionDTO
>
findVersionsByApp
(
Apollo
.
Env
env
,
Stri
ng
appId
)
{
VersionDTO
[]
versions
=
versionAPI
.
getVersionsByApp
(
env
,
appId
);
VersionDTO
[]
versions
=
versionAPI
.
getVersionsByApp
(
env
,
appId
);
if
(
versions
==
null
||
versions
.
length
==
0
){
if
(
versions
==
null
||
versions
.
length
==
0
){
...
...
apollo-portal/src/test/java/com/ctrip/apollo/portal/controller/AppControllerTest.java
View file @
df1c73b7
...
@@ -32,7 +32,7 @@ public class AppControllerTest extends AbstractPortalTest {
...
@@ -32,7 +32,7 @@ public class AppControllerTest extends AbstractPortalTest {
@Test
@Test
public
void
testCreate
()
throws
URISyntaxException
{
public
void
testCreate
()
throws
URISyntaxException
{
App
newApp
=
new
App
();
App
newApp
=
new
App
();
newApp
.
setAppId
(
S
ystem
.
currentTimeMillis
(
));
newApp
.
setAppId
(
S
tring
.
valueOf
(
System
.
currentTimeMillis
()
));
newApp
.
setName
(
"new app "
+
System
.
currentTimeMillis
());
newApp
.
setName
(
"new app "
+
System
.
currentTimeMillis
());
newApp
.
setOwner
(
"owner "
+
System
.
currentTimeMillis
());
newApp
.
setOwner
(
"owner "
+
System
.
currentTimeMillis
());
...
@@ -51,7 +51,7 @@ public class AppControllerTest extends AbstractPortalTest {
...
@@ -51,7 +51,7 @@ public class AppControllerTest extends AbstractPortalTest {
@Test
@Test
public
void
testList
()
throws
URISyntaxException
{
public
void
testList
()
throws
URISyntaxException
{
App
newApp
=
new
App
();
App
newApp
=
new
App
();
newApp
.
setAppId
(
S
ystem
.
currentTimeMillis
(
));
newApp
.
setAppId
(
S
tring
.
valueOf
(
System
.
currentTimeMillis
()
));
newApp
.
setName
(
"new app "
+
System
.
currentTimeMillis
());
newApp
.
setName
(
"new app "
+
System
.
currentTimeMillis
());
newApp
.
setOwner
(
"owner "
+
System
.
currentTimeMillis
());
newApp
.
setOwner
(
"owner "
+
System
.
currentTimeMillis
());
appRepository
.
save
(
newApp
);
appRepository
.
save
(
newApp
);
...
@@ -66,7 +66,7 @@ public class AppControllerTest extends AbstractPortalTest {
...
@@ -66,7 +66,7 @@ public class AppControllerTest extends AbstractPortalTest {
@Test
@Test
public
void
testListOutOfRange
()
throws
URISyntaxException
{
public
void
testListOutOfRange
()
throws
URISyntaxException
{
App
newApp
=
new
App
();
App
newApp
=
new
App
();
newApp
.
setAppId
(
S
ystem
.
currentTimeMillis
(
));
newApp
.
setAppId
(
S
tring
.
valueOf
(
System
.
currentTimeMillis
()
));
newApp
.
setName
(
"new app "
+
System
.
currentTimeMillis
());
newApp
.
setName
(
"new app "
+
System
.
currentTimeMillis
());
newApp
.
setOwner
(
"owner "
+
System
.
currentTimeMillis
());
newApp
.
setOwner
(
"owner "
+
System
.
currentTimeMillis
());
appRepository
.
save
(
newApp
);
appRepository
.
save
(
newApp
);
...
...
apollo-portal/src/test/java/com/ctrip/apollo/portal/repository/AppRepositoryTest.java
View file @
df1c73b7
...
@@ -18,7 +18,7 @@ public class AppRepositoryTest extends AbstractPortalTest {
...
@@ -18,7 +18,7 @@ public class AppRepositoryTest extends AbstractPortalTest {
Assert
.
assertEquals
(
0
,
repository
.
count
());
Assert
.
assertEquals
(
0
,
repository
.
count
());
App
ramdomApp
=
new
App
();
App
ramdomApp
=
new
App
();
ramdomApp
.
setAppId
(
S
ystem
.
currentTimeMillis
(
));
ramdomApp
.
setAppId
(
S
tring
.
valueOf
(
System
.
currentTimeMillis
()
));
ramdomApp
.
setName
(
"new app "
+
System
.
currentTimeMillis
());
ramdomApp
.
setName
(
"new app "
+
System
.
currentTimeMillis
());
ramdomApp
.
setOwner
(
"owner "
+
System
.
currentTimeMillis
());
ramdomApp
.
setOwner
(
"owner "
+
System
.
currentTimeMillis
());
repository
.
save
(
ramdomApp
);
repository
.
save
(
ramdomApp
);
...
...
apollo-portal/src/test/java/com/ctrip/apollo/portal/service/ConfigServiceTest.java
View file @
df1c73b7
...
@@ -3,7 +3,6 @@ package com.ctrip.apollo.portal.service;
...
@@ -3,7 +3,6 @@ package com.ctrip.apollo.portal.service;
import
static
org
.
junit
.
Assert
.
assertEquals
;
import
static
org
.
junit
.
Assert
.
assertEquals
;
import
static
org
.
mockito
.
Mockito
.
when
;
import
static
org
.
mockito
.
Mockito
.
when
;
import
org.junit.Before
;
import
org.junit.Before
;
import
org.junit.Test
;
import
org.junit.Test
;
import
org.junit.runner.RunWith
;
import
org.junit.runner.RunWith
;
...
@@ -63,7 +62,7 @@ public class ConfigServiceTest {
...
@@ -63,7 +62,7 @@ public class ConfigServiceTest {
@Test
@Test
public
void
testLoadReleaseConfig
()
{
public
void
testLoadReleaseConfig
()
{
long
appId
=
6666
;
String
appId
=
"6666"
;
long
versionId
=
100
;
long
versionId
=
100
;
long
releaseId
=
11111
;
long
releaseId
=
11111
;
...
@@ -84,7 +83,7 @@ public class ConfigServiceTest {
...
@@ -84,7 +83,7 @@ public class ConfigServiceTest {
@Test
@Test
public
void
testLoadReleaseConfigOnlyDefaultConfigs
()
{
public
void
testLoadReleaseConfigOnlyDefaultConfigs
()
{
long
appId
=
6666
;
String
appId
=
"6666"
;
long
versionId
=
100
;
long
versionId
=
100
;
long
releaseId
=
11111
;
long
releaseId
=
11111
;
...
@@ -107,7 +106,7 @@ public class ConfigServiceTest {
...
@@ -107,7 +106,7 @@ public class ConfigServiceTest {
@Test
@Test
public
void
testLoadReleaseConfigDefaultConfigsAndOverrideApp
()
{
public
void
testLoadReleaseConfigDefaultConfigsAndOverrideApp
()
{
long
appId
=
6666
;
String
appId
=
"6666"
;
long
versionId
=
100
;
long
versionId
=
100
;
long
releaseId
=
11111
;
long
releaseId
=
11111
;
VersionDTO
someVersion
=
assembleVersion
(
appId
,
"1.0"
,
releaseId
);
VersionDTO
someVersion
=
assembleVersion
(
appId
,
"1.0"
,
releaseId
);
...
@@ -129,7 +128,7 @@ public class ConfigServiceTest {
...
@@ -129,7 +128,7 @@ public class ConfigServiceTest {
@Test
@Test
public
void
testLoadReleaseConfigDefaultConfigsAndOverrideCluster
()
{
public
void
testLoadReleaseConfigDefaultConfigsAndOverrideCluster
()
{
long
appId
=
6666
;
String
appId
=
"6666"
;
long
versionId
=
100
;
long
versionId
=
100
;
long
releaseId
=
11111
;
long
releaseId
=
11111
;
VersionDTO
someVersion
=
assembleVersion
(
appId
,
"1.0"
,
releaseId
);
VersionDTO
someVersion
=
assembleVersion
(
appId
,
"1.0"
,
releaseId
);
...
@@ -153,7 +152,7 @@ public class ConfigServiceTest {
...
@@ -153,7 +152,7 @@ public class ConfigServiceTest {
@Test
@Test
public
void
testLoadLastestConfig
()
{
public
void
testLoadLastestConfig
()
{
long
appId
=
6666
;
String
appId
=
"6666"
;
ClusterDTO
[]
someClusters
=
assembleClusters
();
ClusterDTO
[]
someClusters
=
assembleClusters
();
ConfigItemDTO
[]
someConfigItem
=
assembleConfigItems
();
ConfigItemDTO
[]
someConfigItem
=
assembleConfigItems
();
...
@@ -163,14 +162,14 @@ public class ConfigServiceTest {
...
@@ -163,14 +162,14 @@ public class ConfigServiceTest {
AppConfigVO
appConfigVO
=
configService
.
loadLatestConfig
(
Env
.
DEV
,
appId
);
AppConfigVO
appConfigVO
=
configService
.
loadLatestConfig
(
Env
.
DEV
,
appId
);
assertEquals
(
appConfigVO
.
getAppId
(),
6666
);
assertEquals
(
appConfigVO
.
getAppId
(),
"6666"
);
assertEquals
(
appConfigVO
.
getVersionId
(),
PortalConstants
.
LASTEST_VERSION_ID
);
assertEquals
(
appConfigVO
.
getVersionId
(),
PortalConstants
.
LASTEST_VERSION_ID
);
assertEquals
(
appConfigVO
.
getDefaultClusterConfigs
().
size
(),
3
);
assertEquals
(
appConfigVO
.
getDefaultClusterConfigs
().
size
(),
3
);
assertEquals
(
appConfigVO
.
getOverrideAppConfigs
().
size
(),
1
);
assertEquals
(
appConfigVO
.
getOverrideAppConfigs
().
size
(),
1
);
assertEquals
(
appConfigVO
.
getOverrideClusterConfigs
().
size
(),
1
);
assertEquals
(
appConfigVO
.
getOverrideClusterConfigs
().
size
(),
1
);
}
}
private
VersionDTO
assembleVersion
(
lo
ng
appId
,
String
versionName
,
long
releaseId
)
{
private
VersionDTO
assembleVersion
(
Stri
ng
appId
,
String
versionName
,
long
releaseId
)
{
VersionDTO
version
=
new
VersionDTO
();
VersionDTO
version
=
new
VersionDTO
();
version
.
setAppId
(
appId
);
version
.
setAppId
(
appId
);
version
.
setName
(
versionName
);
version
.
setName
(
versionName
);
...
@@ -198,12 +197,12 @@ public class ConfigServiceTest {
...
@@ -198,12 +197,12 @@ public class ConfigServiceTest {
private
ClusterDTO
[]
assembleClusters
()
{
private
ClusterDTO
[]
assembleClusters
()
{
ClusterDTO
[]
clusters
=
new
ClusterDTO
[
2
];
ClusterDTO
[]
clusters
=
new
ClusterDTO
[
2
];
clusters
[
0
]
=
assembleCluster
(
100
,
6666
,
Constants
.
DEFAULT_CLUSTER_NAME
);
clusters
[
0
]
=
assembleCluster
(
100
,
"6666"
,
Constants
.
DEFAULT_CLUSTER_NAME
);
clusters
[
1
]
=
assembleCluster
(
101
,
6666
,
"cluster1"
);
clusters
[
1
]
=
assembleCluster
(
101
,
"6666"
,
"cluster1"
);
return
clusters
;
return
clusters
;
}
}
private
ClusterDTO
assembleCluster
(
long
id
,
lo
ng
appId
,
String
name
)
{
private
ClusterDTO
assembleCluster
(
long
id
,
Stri
ng
appId
,
String
name
)
{
ClusterDTO
cluster
=
new
ClusterDTO
();
ClusterDTO
cluster
=
new
ClusterDTO
();
cluster
.
setAppId
(
appId
);
cluster
.
setAppId
(
appId
);
cluster
.
setId
(
id
);
cluster
.
setId
(
id
);
...
@@ -213,19 +212,15 @@ public class ConfigServiceTest {
...
@@ -213,19 +212,15 @@ public class ConfigServiceTest {
private
ConfigItemDTO
[]
assembleConfigItems
()
{
private
ConfigItemDTO
[]
assembleConfigItems
()
{
ConfigItemDTO
[]
configItems
=
new
ConfigItemDTO
[
5
];
ConfigItemDTO
[]
configItems
=
new
ConfigItemDTO
[
5
];
configItems
[
0
]
=
configItems
[
0
]
=
assembleConfigItem
(
100
,
Constants
.
DEFAULT_CLUSTER_NAME
,
"6666"
,
"6666.k1"
,
"6666.v1"
);
assembleConfigItem
(
100
,
Constants
.
DEFAULT_CLUSTER_NAME
,
6666
,
"6666.k1"
,
"6666.v1"
);
configItems
[
1
]
=
assembleConfigItem
(
100
,
Constants
.
DEFAULT_CLUSTER_NAME
,
"6666"
,
"6666.k2"
,
"6666.v2"
);
configItems
[
1
]
=
configItems
[
2
]
=
assembleConfigItem
(
100
,
Constants
.
DEFAULT_CLUSTER_NAME
,
"6666"
,
"6666.k3"
,
"6666.v3"
);
assembleConfigItem
(
100
,
Constants
.
DEFAULT_CLUSTER_NAME
,
6666
,
"6666.k2"
,
"6666.v2"
);
configItems
[
3
]
=
assembleConfigItem
(
100
,
Constants
.
DEFAULT_CLUSTER_NAME
,
"5555"
,
"5555.k1"
,
"5555.v1"
);
configItems
[
2
]
=
configItems
[
4
]
=
assembleConfigItem
(
101
,
"cluster1"
,
"6666"
,
"6666.k1"
,
"6666.v1"
);
assembleConfigItem
(
100
,
Constants
.
DEFAULT_CLUSTER_NAME
,
6666
,
"6666.k3"
,
"6666.v3"
);
configItems
[
3
]
=
assembleConfigItem
(
100
,
Constants
.
DEFAULT_CLUSTER_NAME
,
5555
,
"5555.k1"
,
"5555.v1"
);
configItems
[
4
]
=
assembleConfigItem
(
101
,
"cluster1"
,
6666
,
"6666.k1"
,
"6666.v1"
);
return
configItems
;
return
configItems
;
}
}
private
ConfigItemDTO
assembleConfigItem
(
long
clusterId
,
String
clusterName
,
int
appId
,
private
ConfigItemDTO
assembleConfigItem
(
long
clusterId
,
String
clusterName
,
String
appId
,
String
key
,
String
value
)
{
String
key
,
String
value
)
{
ConfigItemDTO
configItem
=
new
ConfigItemDTO
();
ConfigItemDTO
configItem
=
new
ConfigItemDTO
();
configItem
.
setClusterName
(
clusterName
);
configItem
.
setClusterName
(
clusterName
);
...
...
apollo-portal/src/test/java/com/ctrip/apollo/portal/service/PrivilegeServiceTest.java
View file @
df1c73b7
...
@@ -21,7 +21,7 @@ public class PrivilegeServiceTest extends AbstractPortalTest {
...
@@ -21,7 +21,7 @@ public class PrivilegeServiceTest extends AbstractPortalTest {
@Test
@Test
public
void
testAddAndRemovePrivilege
()
{
public
void
testAddAndRemovePrivilege
()
{
App
newApp
=
new
App
();
App
newApp
=
new
App
();
newApp
.
setAppId
((
System
.
currentTimeMillis
()));
newApp
.
setAppId
(
String
.
valueOf
(
System
.
currentTimeMillis
()));
newApp
.
setName
(
"new app "
+
System
.
currentTimeMillis
());
newApp
.
setName
(
"new app "
+
System
.
currentTimeMillis
());
newApp
.
setOwner
(
"owner "
+
System
.
currentTimeMillis
());
newApp
.
setOwner
(
"owner "
+
System
.
currentTimeMillis
());
appService
.
save
(
newApp
);
appService
.
save
(
newApp
);
...
@@ -42,7 +42,7 @@ public class PrivilegeServiceTest extends AbstractPortalTest {
...
@@ -42,7 +42,7 @@ public class PrivilegeServiceTest extends AbstractPortalTest {
@Test
@Test
public
void
testCheckPrivilege
()
{
public
void
testCheckPrivilege
()
{
App
newApp
=
new
App
();
App
newApp
=
new
App
();
newApp
.
setAppId
((
System
.
currentTimeMillis
()));
newApp
.
setAppId
(
String
.
valueOf
(
System
.
currentTimeMillis
()));
newApp
.
setName
(
"new app "
+
System
.
currentTimeMillis
());
newApp
.
setName
(
"new app "
+
System
.
currentTimeMillis
());
newApp
.
setOwner
(
"owner "
+
System
.
currentTimeMillis
());
newApp
.
setOwner
(
"owner "
+
System
.
currentTimeMillis
());
appService
.
save
(
newApp
);
appService
.
save
(
newApp
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment