Merge pull request #1212 from nobodyiam/fix-404-exception

when server returns status code other than 200 and 304, we should throw ApolloConfigStatusCodeException

apollo-client/src/main/java/com/ctrip/framework/apollo/exceptions/ApolloConfigStatusCodeException.java

@@ -11,6 +11,11 @@ public class ApolloConfigStatusCodeException extends RuntimeException{
     this.m_statusCode = statusCode;
   }
 
+  public ApolloConfigStatusCodeException(int statusCode, Throwable cause) {
+    super(cause);
+    this.m_statusCode = statusCode;
+  }
+
   public int getStatusCode() {
     return m_statusCode;
   }

apollo-client/src/main/java/com/ctrip/framework/apollo/util/http/HttpUtil.java

@@ -116,7 +116,13 @@ public class HttpUtil {
           }
         }
 
+        // 200 and 304 should not trigger IOException, thus we must throw the original exception out
+        if (statusCode == 200 || statusCode == 304) {
           throw ex;
+        } else {
+          // for status codes like 404, IOException is expected when calling conn.getInputStream()
+          throw new ApolloConfigStatusCodeException(statusCode, ex);
+        }
       }
 
       if (statusCode == 200) {
@@ -126,6 +132,8 @@ public class HttpUtil {
       if (statusCode == 304) {
         return new HttpResponse<>(statusCode, null);
       }
+    } catch (ApolloConfigStatusCodeException ex) {
+      throw ex;
     } catch (Throwable ex) {
       throw new ApolloConfigException("Could not complete get operation", ex);
     } finally {