The following document contains the results of Checkstyle 6.18 with google_checks.xml ruleset. 
| Category | Rule | Violations | Severity |
|---|---|---|---|
| blocks | NeedBraces | 6 | |
| coding | OverloadMethodsDeclarationOrder | 1 | |
| VariableDeclarationUsageDistance | 1 | ||
| imports | CustomImportOrder
|
50 | |
| indentation | CommentsIndentation | 3 | |
| javadoc | JavadocMethod
|
17 | |
| JavadocParagraph | 4 | ||
| NonEmptyAtclauseDescription | 6 | ||
SummaryJavadoc
|
7 | ||
| naming | CatchParameterName
|
7 | |
LocalVariableName
|
2 | ||
ParameterName
|
2 | ||
| sizes | LineLength
|
6 | |
| whitespace | GenericWhitespace | 1 | |
WhitespaceAround
|
16 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Wrong lexicographical order for 'com.ctrip.framework.apollo.Apollo' import. Should be before 'org.springframework.web.bind.annotation.RestController'. | 6 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'com.ctrip.framework.foundation.Foundation' import. Should be before 'org.springframework.web.bind.annotation.RestController'. | 7 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Import statement for 'org.springframework.boot.context.embedded.FilterRegistrationBean' is in the wrong order. Should be in the 'THIRD_PARTY_PACKAGE' group, expecting not assigned imports on this line. | 5 | |
| imports | CustomImportOrder | Import statement for 'org.springframework.boot.context.embedded.ServletListenerRegistrationBean' is in the wrong order. Should be in the 'THIRD_PARTY_PACKAGE' group, expecting not assigned imports on this line. | 6 | |
| imports | CustomImportOrder | Import statement for 'org.springframework.context.annotation.Bean' is in the wrong order. Should be in the 'THIRD_PARTY_PACKAGE' group, expecting not assigned imports on this line. | 7 | |
| imports | CustomImportOrder | Import statement for 'org.springframework.context.annotation.Configuration' is in the wrong order. Should be in the 'THIRD_PARTY_PACKAGE' group, expecting not assigned imports on this line. | 8 | |
| imports | CustomImportOrder | Import statement for 'com.dianping.cat.servlet.CatFilter' is in the wrong order. Should be in the 'THIRD_PARTY_PACKAGE' group, expecting not assigned imports on this line. | 10 | |
| imports | CustomImportOrder | Import statement for 'com.dianping.cat.servlet.CatListener' is in the wrong order. Should be in the 'THIRD_PARTY_PACKAGE' group, expecting not assigned imports on this line. | 11 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 16 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 26 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Import statement for 'org.springframework.boot.context.embedded.FilterRegistrationBean' is in the wrong order. Should be in the 'THIRD_PARTY_PACKAGE' group, expecting not assigned imports on this line. | 5 | |
| imports | CustomImportOrder | Import statement for 'org.springframework.context.annotation.Bean' is in the wrong order. Should be in the 'THIRD_PARTY_PACKAGE' group, expecting not assigned imports on this line. | 6 | |
| imports | CustomImportOrder | Import statement for 'org.springframework.context.annotation.Configuration' is in the wrong order. Should be in the 'THIRD_PARTY_PACKAGE' group, expecting not assigned imports on this line. | 7 | |
| imports | CustomImportOrder | Import statement for 'org.springframework.web.filter.CharacterEncodingFilter' is in the wrong order. Should be in the 'THIRD_PARTY_PACKAGE' group, expecting not assigned imports on this line. | 8 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 13 | |
| indentation | CommentsIndentation | Comment has incorrect indentation level 4, expected is 0, indentation should be the same level as line 19. | 18 | |
| indentation | CommentsIndentation | Comment has incorrect indentation level 0, expected is 4, indentation should be the same level as line 20. | 19 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Wrong lexicographical order for 'com.ctrip.framework.apollo.core.exception.AbstractBaseException' import. Should be before 'org.springframework.web.client.HttpStatusCodeException'. | 15 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'com.ctrip.framework.apollo.core.exception.BadRequestException' import. Should be before 'org.springframework.web.client.HttpStatusCodeException'. | 16 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'com.ctrip.framework.apollo.core.exception.NotFoundException' import. Should be before 'org.springframework.web.client.HttpStatusCodeException'. | 17 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'com.dianping.cat.Cat' import. Should be before 'org.springframework.web.client.HttpStatusCodeException'. | 18 | |
| imports | CustomImportOrder | Import statement for 'com.google.gson.Gson' is in the wrong order. Should be in the 'SPECIAL_IMPORTS' group, expecting group 'STANDARD_JAVA_PACKAGE' on this line. | 19 | |
| imports | CustomImportOrder | Import statement for 'com.google.gson.reflect.TypeToken' is in the wrong order. Should be in the 'SPECIAL_IMPORTS' group, expecting group 'STANDARD_JAVA_PACKAGE' on this line. | 20 | |
| imports | CustomImportOrder | Import statement for 'org.springframework.http.HttpStatus.BAD_REQUEST' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line. | 31 | |
| imports | CustomImportOrder | Import statement for 'org.springframework.http.HttpStatus.INTERNAL_SERVER_ERROR' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line. | 32 | |
| imports | CustomImportOrder | Import statement for 'org.springframework.http.HttpStatus.NOT_FOUND' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line. | 33 | |
| imports | CustomImportOrder | Import statement for 'org.springframework.http.HttpStatus.UNAUTHORIZED' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line. | 34 | |
| imports | CustomImportOrder | Import statement for 'org.springframework.http.MediaType.APPLICATION_JSON' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line. | 35 | |
| sizes | LineLength | Line is longer than 100 characters (found 109). | 58 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 68 | |
| sizes | LineLength | Line is longer than 100 characters (found 108). | 90 | |
| indentation | CommentsIndentation | Comment has incorrect indentation level 0, expected is 4, indentation should be the same level as line 105. | 104 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| javadoc | JavadocMethod | Missing a Javadoc comment. | 22 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Import statement for 'org.springframework.context.annotation.Configuration' is in the wrong order. Should be in the 'THIRD_PARTY_PACKAGE' group, expecting not assigned imports on this line. | 5 | |
| imports | CustomImportOrder | Import statement for 'org.springframework.data.domain.PageRequest' is in the wrong order. Should be in the 'THIRD_PARTY_PACKAGE' group, expecting not assigned imports on this line. | 6 | |
| imports | CustomImportOrder | Import statement for 'org.springframework.data.web.PageableHandlerMethodArgumentResolver' is in the wrong order. Should be in the 'THIRD_PARTY_PACKAGE' group, expecting not assigned imports on this line. | 7 | |
| imports | CustomImportOrder | Import statement for 'org.springframework.http.MediaType' is in the wrong order. Should be in the 'THIRD_PARTY_PACKAGE' group, expecting not assigned imports on this line. | 8 | |
| imports | CustomImportOrder | Import statement for 'org.springframework.web.method.support.HandlerMethodArgumentResolver' is in the wrong order. Should be in the 'THIRD_PARTY_PACKAGE' group, expecting not assigned imports on this line. | 9 | |
| imports | CustomImportOrder | Import statement for 'org.springframework.web.servlet.config.annotation.ContentNegotiationConfigurer' is in the wrong order. Should be in the 'THIRD_PARTY_PACKAGE' group, expecting not assigned imports on this line. | 10 | |
| imports | CustomImportOrder | Import statement for 'org.springframework.web.servlet.config.annotation.WebMvcConfigurerAdapter' is in the wrong order. Should be in the 'THIRD_PARTY_PACKAGE' group, expecting not assigned imports on this line. | 11 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Wrong lexicographical order for 'ch.qos.logback.classic.LoggerContext' import. Should be before 'org.springframework.util.ReflectionUtils'. | 15 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'ch.qos.logback.core.Appender' import. Should be before 'org.springframework.util.ReflectionUtils'. | 16 | |
| coding | VariableDeclarationUsageDistance | Distance between variable 'loggerContext' declaration and its first usage is 5, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). | 52 | |
| naming | LocalVariableName | Local variable name 'cLoggingAppender' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 54 | |
| javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 72 | |
| javadoc | NonEmptyAtclauseDescription | At-clause should have a non-empty description. | 74 | |
| javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 78 | |
| javadoc | NonEmptyAtclauseDescription | At-clause should have a non-empty description. | 80 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Wrong lexicographical order for 'com.ctrip.framework.apollo.core.utils.StringUtils' import. Should be before 'org.springframework.core.type.AnnotatedTypeMetadata'. | 7 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Import statement for 'org.springframework.beans.factory.annotation.Autowired' is in the wrong order. Should be in the 'THIRD_PARTY_PACKAGE' group, expecting not assigned imports on this line. | 7 | |
| imports | CustomImportOrder | Import statement for 'org.springframework.context.annotation.Bean' is in the wrong order. Should be in the 'THIRD_PARTY_PACKAGE' group, expecting not assigned imports on this line. | 8 | |
| imports | CustomImportOrder | Import statement for 'org.springframework.context.annotation.Conditional' is in the wrong order. Should be in the 'THIRD_PARTY_PACKAGE' group, expecting not assigned imports on this line. | 9 | |
| imports | CustomImportOrder | Import statement for 'org.springframework.stereotype.Component' is in the wrong order. Should be in the 'THIRD_PARTY_PACKAGE' group, expecting not assigned imports on this line. | 10 | |
| imports | CustomImportOrder | Import statement for 'com.dianping.cat.Cat' is in the wrong order. Should be in the 'THIRD_PARTY_PACKAGE' group, expecting not assigned imports on this line. | 12 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 21 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Wrong lexicographical order for 'com.ctrip.framework.apollo.core.enums.Env' import. Should be before 'org.springframework.stereotype.Component'. | 6 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'com.ctrip.framework.apollo.core.enums.EnvUtils' import. Should be before 'org.springframework.stereotype.Component'. | 7 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'com.ctrip.framework.foundation.Foundation' import. Should be before 'org.springframework.stereotype.Component'. | 8 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 31 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 50 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| javadoc | JavadocMethod | Missing a Javadoc comment. | 82 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| naming | ParameterName | Parameter name 'aPublic' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 62 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Import statement for 'com.google.common.base.MoreObjects' is in the wrong order. Should be in the 'SPECIAL_IMPORTS' group, expecting not assigned imports on this line. | 15 | |
| imports | CustomImportOrder | Import statement for 'com.google.common.base.MoreObjects.ToStringHelper' is in the wrong order. Should be in the 'SPECIAL_IMPORTS' group, expecting not assigned imports on this line. | 16 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 92 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 93 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 114 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 8 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 29 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 30 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| whitespace | GenericWhitespace | GenericWhitespace '>' should followed by whitespace. | 5 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 5 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 11 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 11 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 19 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 19 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Import statement for 'org.springframework.beans.BeanWrapper' is in the wrong order. Should be in the 'THIRD_PARTY_PACKAGE' group, expecting not assigned imports on this line. | 13 | |
| imports | CustomImportOrder | Import statement for 'org.springframework.beans.BeanWrapperImpl' is in the wrong order. Should be in the 'THIRD_PARTY_PACKAGE' group, expecting not assigned imports on this line. | 14 | |
| imports | CustomImportOrder | Import statement for 'org.springframework.util.CollectionUtils' is in the wrong order. Should be in the 'THIRD_PARTY_PACKAGE' group, expecting not assigned imports on this line. | 15 | |
| javadoc | JavadocParagraph | Javadoc comment at column 14 has parse error. Missed HTML close tag 'UserDTO'. Sometimes it means that close tag missed for one of previous tags. | 23 | |
| naming | CatchParameterName | Catch parameter name 'e' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 53 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 67 | |
| javadoc | JavadocParagraph | Javadoc comment at column 22 has parse error. Details: no viable alternative at input '<pre>\n * List<UserDTO> userList = userService.queryUsers();\n * Map<Integer,' while parsing HTML_TAG | 78 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 92 | |
| naming | CatchParameterName | Catch parameter name 'e' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 97 | |
| javadoc | JavadocParagraph | Javadoc comment at column 23 has parse error. Details: no viable alternative at input '<pre>\n * List<ShopDTO> shopList = shopService.queryShops();\n * Map<Integer,' while parsing HTML_TAG | 108 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not followed by whitespace. Empty blocks may only be represented as {} when not part of a multi-block statement (4.1.3) | 114 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 120 | |
| naming | LocalVariableName | Local variable name 'k' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 123 | |
| naming | CatchParameterName | Catch parameter name 'e' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 129 | |
| javadoc | JavadocParagraph | Javadoc comment at column 13 has parse error. Missed HTML close tag 'Integer'. Sometimes it means that close tag missed for one of previous tags. | 140 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not followed by whitespace. Empty blocks may only be represented as {} when not part of a multi-block statement (4.1.3) | 146 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 152 | |
| naming | CatchParameterName | Catch parameter name 'e' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 157 | |
| naming | CatchParameterName | Catch parameter name 'e' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 172 | |
| javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 179 | |
| naming | CatchParameterName | Catch parameter name 'e' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 189 | |
| javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 195 | |
| naming | CatchParameterName | Catch parameter name 'e' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 205 | |
| javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 210 | |
| javadoc | NonEmptyAtclauseDescription | At-clause should have a non-empty description. | 212 | |
| javadoc | NonEmptyAtclauseDescription | At-clause should have a non-empty description. | 213 | |
| javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 219 | |
| javadoc | NonEmptyAtclauseDescription | At-clause should have a non-empty description. | 222 | |
| javadoc | NonEmptyAtclauseDescription | At-clause should have a non-empty description. | 223 | |
| sizes | LineLength | Line is longer than 100 characters (found 143). | 229 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Import statement for 'org.springframework.web.client.HttpStatusCodeException' is in the wrong order. Should be in the 'THIRD_PARTY_PACKAGE' group, expecting not assigned imports on this line. | 6 | |
| imports | CustomImportOrder | Import statement for 'com.google.common.base.MoreObjects' is in the wrong order. Should be in the 'SPECIAL_IMPORTS' group, expecting not assigned imports on this line. | 8 | |
| imports | CustomImportOrder | Import statement for 'com.google.gson.Gson' is in the wrong order. Should be in the 'SPECIAL_IMPORTS' group, expecting not assigned imports on this line. | 9 | |
| imports | CustomImportOrder | Import statement for 'com.google.gson.reflect.TypeToken' is in the wrong order. Should be in the 'SPECIAL_IMPORTS' group, expecting not assigned imports on this line. | 10 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 18 | |
| naming | ParameterName | Parameter name 'e' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 18 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| sizes | LineLength | Line is longer than 100 characters (found 113). | 13 | |
| sizes | LineLength | Line is longer than 100 characters (found 112). | 15 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 27 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 27 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 28 | |
| sizes | LineLength | Line is longer than 100 characters (found 124). | 31 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 21 | |
| coding | OverloadMethodsDeclarationOrder | Overload methods should not be split. Previous overloaded method located at line '17'. | 25 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 25 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 31 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 31 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 32 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 33 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 39 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 39 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 40 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 41 |